1638275 - The search panel one offs container is not hidden after removing several search engines

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Address bar search.gif

Affected versions

• Firefox 76.0.1 (BuildId:20200507114007)
• Firefox 77.0b6 (BuildId:20200514211331)
• Firefox 78.0a1 (BuildId:20200514211114)

Unaffected versions

• Firefox 68.8.0esr (BuildId:20200429190206)

Affected platforms

• macOS 10.14
• Windows 10 64bit
• Ubuntu 18.04 64bit

Steps to reproduce

1. Launch Firefox.
2. Access the about:preferences#search page.
3. Click the “Add search bar in toolbar” radio button.
4. Type a random string inside the search bar.
5. Remove several Search Engines (from the “One-Click Search Engines” section inside the about:preferences#search page) until you only have one left.
6. Type a random string inside the search bar.

Expected result

• The search panel one offs container is hidden.

Actual result

• The search panel one offs container is displayed which causes unused extra space inside the PopupSearchAutoComplete panel.

Regression Range
This seems to be a regression:

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f246623260ee3b80c2021c48f5d56f54073f8060&tochange=8d2d3b3fb7e27f0bd238985c265b4f50dc10bc05
• Regressed by: Bug 1561894

Notes

• This issue is not reproducible if the search engines are removed beforehand and the search bar is added after.
• The search panel one offs container seems to get hidden only after a browser restart.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Harry,

It seems that mozregression pointed out Bug 1561894 - Implement simplified one-off search button design. r=dao for causing this regression.

Can you please have a look?

Thanks!

Comment 2

[Harry Twyford]

Thanks, I'll look into this.

Comment 3

[Harry Twyford]

Attachment: Bug 1638275 - Allow searchbar one-offs hidden attribute to override display:flex. r?dao

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3de491b80e70
Allow searchbar one-offs hidden attribute to override display:flex. r=dao

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 3de491b80e70 (Bug 1638275) for causing failures in browser_searchbar_openpopup.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=X03h8d95T7qJS7KPl_yFHA-0&resultStatus=testfailed%2Cbusted%2Cexception&revision=3de491b80e70d7f880caed68853d74d4d9d144d3

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304539799&repo=autoland&lineNumber=26098

Backout: https://hg.mozilla.org/integration/autoland/rev/385b328afa95ce98028fbf0e0c74fd9c4ec49f01

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2275d4ff86aa
Allow searchbar one-offs hidden attribute to override display:flex. r=dao

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2275d4ff86aa

Comment 8

[Pablo]

verified on win10 64bit, macos 10.15, and ubuntu 18.04 on latest nightly 79.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider nominating for uplift to Beta78?

Comment 10

[Harry Twyford]

Comment on attachment 9152118 [details]
Bug 1638275 - Allow searchbar one-offs hidden attribute to override display:flex. r?dao

Beta/Release Uplift Approval Request

• User impact if declined: UI bug in the separate search bar when the user has just one search engine installed. This is particularly relevant for ESR, where users are more likely to have non-default search engine configurations installed by their workplace admins.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line CSS change with a test. Already verified by QA.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9152118 [details]
Bug 1638275 - Allow searchbar one-offs hidden attribute to override display:flex. r?dao

approved for 78.0b5

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed091561d4c1

Comment 13

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I verified this issue using Fx 78.0 on Windows 10 and macOS.