1638360 - WebExtension bookmarks context menu will appear in the "Most Visited" folder for bookmarks that have no bookmark id

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P5)

Description

[kernp25]

Attachment: firefox_SCCY1tt5Wm.png

AR:

The context menu item will appear for these bookmarks in the bookmarks toolbar.

Note: In the library window the context menu item will not appear for bookmarks inside the "Most Visited" folder.

Comment 1

[kernp25]

Attachment: firefox_FtEDN7JVqo.png

Comment 2

[kernp25]

Attachment: manifest.zip

Comment 3

[kernp25]

(In reply to kernp25 from comment #0)

Note: In the library window the context menu item will not appear for bookmarks inside the "Most Visited" folder.

The same is also with the bookmarks sidebar.

Comment 4

[kernp25]

Attachment: 41VPdjeTgn.png

Comment 5

[Rob Wu [:robwu]]

How did you get this folder to appear? I think that I've seen it before in the past, but it doesn't appear in a new profile.

Could you open the places.sqlite file from your profile directory and show the result of:

sqlite3 places.sqlite 'select * from moz_bookmarks where title = "Most Visited"'

To get an idea of how to interpret the output, here is the definition of the table.

sqlite3 places.sqlite '.schema moz_bookmarks'

CREATE TABLE moz_bookmarks (  id INTEGER PRIMARY KEY, type INTEGER, fk INTEGER DEFAULT NULL, parent INTEGER, position INTEGER, title LONGVARCHAR, keyword_id INTEGER, folder_type TEXT, dateAdded INTEGER, lastModified INTEGER, guid TEXT, syncStatus INTEGER NOT NULL DEFAULT 0, syncChangeCounter INTEGER NOT NULL DEFAULT 1);
...

Comment 7

[kernp25]

(In reply to Rob Wu [:robwu] from comment #5)

How did you get this folder to appear?

You don't have this folder?

I have this folder, since i installed Firefox.

Comment 8

[Rob Wu [:robwu]]

Those bookmarks were automatically added when the browser profile was created, but that stopped 2 years ago with bug 1446325.

I cannot create them again through the bookmark menu, but I can, through the bookmarks.create API, like this:

await browser.bookmarks.create({
  title:  'Most Visited',
  url: 'place:sort=8&maxResults=10',
  parentId:'toolbar_____'
})

I don't know why the ID is missing, but cannot debug it since i don't have that bookmark of yours.
If you want to help with debugging, share the part from places.sqlite from comment 5. If you don't have the sqlite3 program and are willing to share the database of your bookmarks and history, send places.sqlite to me by mail. It contains sensitive information, so to make sure that it is saved in as few places as possible (i.e. not saved on intermediate mail servers), generate a one-time link via https://send.firefox.com and mail me the link. I will download your file for debugging only, and remove it afterwards.

Comment 9

[kernp25]

152|1|6|3|0|Most Visited|||1492090248054000|1492090248111000|lL2U-b5xRYm4|1|1

Comment 10

[kernp25]

Attachment: firefox_AZ8oi4YicN.png

Comment 11

[Rob Wu [:robwu]]

To fix this bug, this condition:

      if (!trigger._placesNode) {
        return;
      }

should be changed to

      if (!trigger._placesNode?.bookmarkGuid) {
        return;
      }

at https://searchfox.org/mozilla-central/rev/4bb2401ecbfce89af06fb2b4d0ea3557682bd8ff/browser/components/extensions/parent/ext-menus.js#1168

Comment 12

[Sonia]

Attachment: Bug 1638360 - Only show bookmark menu items for nodes with a bookmarkGuid. r=robwu

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f01316d43bf0
Only show bookmark menu items for nodes with a bookmarkGuid. r=robwu

Comment 14

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f01316d43bf0