1638563 - Standard Windows keys do not press button in About dialog

Status: VERIFIED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[psn]

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Open "About Daily" dialog
It would check for updates and show either "Update..." or "Restart.." button if an update was found.

Actual results:

Focused button ignores Space and Enter keys.
Mouse click and Alt+hot letter key do work.

This behaviour appeared several versions ago; and similar issues were fixed previously.

Expected results:

Standard Windows keys should press the button.

Comment 1

[Wayne Mery (:wsmwk)]

psn, thanks for the report.
I confirm this happens on Windows - both version 68 and 78. Works in Firefox.
I don't know how this is supposed to behave on Mac

Comment 2

[Richard Marti (:Paenglab)]

I compared the FX and TB aboutDialog files and can't find why they behave differently.

Comment 3

[Richard Marti (:Paenglab)]

Had today an update on Daily. The difference is, that the buttons aren't focused initially. With two tabs the button is focused and space and enter keys are working.

Comment 4

[psn]

Indeed, after two tabs I could use space key to begin the update.
But there was more.
The button changed to "Restart..." on download completion, and then space key was pressed again, the TB did not restart, but tried to download again, though the progress counter remained at zero.
Pressing sequece of keys "Esc - Alt+H - A" re-opened the dialog, and this time the space key (after two tabs) could restart the TB. Sometimes Firefox also attempted to repeat downloading when "Restart..." button was pressed.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1638563-aboutDialog-button-focus.patch

This should fix the issue by setting the focus to the button. The option enables the focusing here: https://searchfox.org/comm-central/rev/a740e4921d0ccedc5ad1bf0496a337aac3136406/mail/base/content/aboutDialog-appUpdater.js#228

Comment 6

[Richard Marti (:Paenglab)]

I couldn't test this with my self built Daily but it's the same as FX does. I will do the check with the next Daily when the patch landed and ask then for uplifts.

Comment 7

[Richard Marti (:Paenglab)]

Comment on attachment 9162465 [details] [diff] [review]
1638563-aboutDialog-button-focus.patch

[Approval Request Comment]
User impact if declined: lesser accessibility of the about dialog
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c9e0f1e84e6e
Set the focus automatically to the Update/Restart button in "About Thunderbird" dialog. r=mkmelin

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9162465 [details] [diff] [review]
1638563-aboutDialog-button-focus.patch

Approved for beta

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9162465 [details] [diff] [review]
1638563-aboutDialog-button-focus.patch

Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 79.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b8a21ca95117

Comment 12

[Rob Lemley [:rjl]]

Thunderbird 78.0.1:
https://hg.mozilla.org/releases/comm-esr78/rev/22cfe5e9fd61

Comment 13

[Richard Marti (:Paenglab)]

Checked with Daily. The buttons are now focused.