Unifinder selectionbar colors do not match with theme

RESOLVED FIXED

Status

Calendar
Sunbird Only
RESOLVED FIXED
16 years ago
12 years ago

People

(Reporter: ajbu, Assigned: Mike Potter)

Tracking

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
From bug 160732 reported by alge@samsen.com:

The Calendar unifinder(sidebar) uses a lightblue color for the selectionbar.
While I like that color, it doesn't match with any other selections for that 
theme in Mozilla (mail/news, sidebar..)
Is there any objection to removing the selection colors from the calendar.css 
and use the colors provided by Mozilla/listbox?

See also: http://alge.nlc.no/~alge/cal.png (current situation)
(Reporter)

Comment 1

16 years ago
Created attachment 96170 [details]
screenshot unifinder with all background colors removed from calendar.css
(Assignee)

Comment 2

16 years ago
No. In general in all instances of Calendar we should try and mimick the colors,
wordings, and placements of icons and menu items as closely as possible to
existing Mozilla apps, like Mail, Composer and Browser.
AJB: You want this one?
(Reporter)

Comment 3

16 years ago
I'll make the patch
Assignee: mikep → ajbu
(Assignee)

Comment 4

16 years ago
AJB: I think it would be good if you add me to the CC list for bugs you take, so
I know when patches are done.
(Reporter)

Comment 5

16 years ago
Created attachment 96185 [details] [diff] [review]
css skin cleanup / remove of unifinder selection colors

Patch:
- cleanup mox-box typos
- change left/right to start/end for -moz-box-align (l/r are invalid)
- removed toolbar background for classic, classic doesn't have a
toolbar-background
- removed al styles for unifinder selections, so the theme settings for listbox
is used.
(Assignee)

Comment 6

16 years ago
Patch added to my build here, but not checked into cvs.
Fixes to do: 
1. When you click on a task item, the text needs to change from black to white.
(This might get tricky with the different colors that we need for completed
tasks, in progress tasks...)
Since I did that in the first place, I'll take this bug now to fix that.
Assignee: ajbu → mikep
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 7

16 years ago
You might simply add:
treechildren:-moz-tree-cell-text(selected) {
   color                  : -moz-Dialog;
}

selected is added as a property by the tree, setting al text color when 
selection.
(Reporter)

Comment 8

16 years ago
that should be:   
color                  : HighlightText;
(Assignee)

Comment 9

16 years ago
How does it get HighlightText?
(Reporter)

Comment 10

16 years ago
Just tried it out, adding this to calendar.css after the other colors:
treechildren:-moz-tree-cell-text(focus, selected) {
   color                  : HighlightText;
}

sets te selected text to white, setting the focus on the event-unifinder 
restores the color.
(Assignee)

Comment 11

16 years ago
This is fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: colint → sunbird
You need to log in before you can comment on or make changes to this bug.