Closed Bug 1638743 Opened 4 years ago Closed 4 months ago

Target.createTarget doesn't emit Target.attachedToTarget event when "setAutoAttach" is enabled

Categories

(Remote Protocol :: CDP, task, P3)

task

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: whimboo, Unassigned)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

When creating a new target via Target.createTarget the Target.attachedToTarget event has to be sent out. Right now that isn't done:

https://searchfox.org/mozilla-central/rev/09b8072a543c145de2dc9bb76eddddd4a6c09adc/remote/domains/parent/Target.jsm#85-96

We need support for Target.setAutoAttach first, which will be implemented via bug 1636980.

Depends on: 1636980
Whiteboard: [puppeteer-beta-reserve] → [puppeteer-beta2-mvp]
Component: CDP: Target → CDP

When creating a new target via Target.createTarget the Target.attachedToTarget event has to be sent out.

FYI: This seems outdated, or at least I cannot recreate with latest Chromium. The event is never sent out with just Target.createTarget.

(In reply to CanadaHonk [:CanadaHonk] from comment #2)

When creating a new target via Target.createTarget the Target.attachedToTarget event has to be sent out.

FYI: This seems outdated, or at least I cannot recreate with latest Chromium. The event is never sent out with just Target.createTarget.

Did you check with Target.setAutoAttach set to true? Maybe you missed my comment 1?

Flags: needinfo?(oj)

Ah, presumed it meant always from the title, whoops, disregard.

Flags: needinfo?(oj)

Good point. Updating the summary to reflect that.

Summary: Target.createTarget doesn't emit Target.attachedToTarget event → Target.createTarget doesn't emit Target.attachedToTarget event when "setAutoAttach" is enabled

We are not going to fix this API for CDP.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.