Open Bug 1638831 Opened 4 years ago Updated 1 year ago

QM: Directory traversals prematurely finish if a directory entry is modified and then deleted

Categories

(Core :: Storage: Quota Manager, defect, P3)

defect

Tracking

()

People

(Reporter: janv, Unassigned)

Details

(Keywords: leave-open, Whiteboard: [storage-jv])

Attachments

(2 files)

I've noticed this when I was working on fixes for ignoring unknown files.

Basically, if an origin directory is missing the metadata file during a clear operation, the metadata will be restored (which probably modifies the current directory entry of the traversal). If the origin directory also matches the scope, it will be deleted. However, the directory traversal finishes after that.

I verified this on the try server and it's a problem on all platforms:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f71c07f2b650551d3cacd553931ff73b56b5bb4d

For now, I'll just modify a test with a TODO comment, so we don't forget about it.

Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by jvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/528ca16f21cb
Clean up the test for clearStoragesForOriginAttributesPattern(); r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/bc0a37f04241
Rename clearStorageForPrincipal to clearStoragesForPrincipal in tests; r=dom-workers-and-storage-reviewers,ttung

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Flags: needinfo?(jvarga)

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Flags: needinfo?(jvarga)

The leave-open keyword is there and there is no activity for 6 months.
:janv, maybe it's time to close this bug?

Flags: needinfo?(jvarga)

As the patches seem to touch only tests, I assume this is still open. Jan, are you planning to work on this?

Flags: needinfo?(jvarga)
Flags: needinfo?(jvarga)
Assignee: jvarga → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(jvarga)
Whiteboard: [storage-jv]

The leave-open keyword is there and there is no activity for 6 months.
:edenchuang, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(echuang)

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #9)

:edenchuang, maybe it's time to close this bug?

No.

Flags: needinfo?(echuang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: