1638863 - Convert some images in Calendar to SVG

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Richard Marti (:Paenglab)]

We can easely convert some images to SVG in Calendar.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1638863-calendar-SVG.patch

This patch removes the checkmark images and uses our SVGs. Also the Task lo-prio icon in the task tree is now a SVG.
The cal-icon24.png is no more used with the account central refresh.

Comment 2

[Richard Marti (:Paenglab)]

We have still PNGs for the attendee dialog. This seems to be a bigger job and should be done in a new bug.

Comment 3

[Alessandro Castellani [:aleca]]

Comment on attachment 9149873 [details] [diff] [review]
1638863-calendar-SVG.patch

Review of attachment 9149873 [details] [diff] [review]:
-----------------------------------------------------------------

This is good, thanks for taking care of this.

I'm not super convinced about the Checkbox in the calendar sidebar as we're planning to replace that with the eye icon to control visibility in bug 1621135.
It looks a bit strange, I'm not sure. I guess it's fine and we can deal with that overall UI update in that bug.

Once thing if you could update is the Priority indicator in the Task creation dialog.
Now uses 3 black boxes, which is very weird and non intuitive. We should replace that with the icons you implemented.

Comment 4

[Paul Morris [:pmorris]]

Comment on attachment 9149873 [details] [diff] [review]
1638863-calendar-SVG.patch

Review of attachment 9149873 [details] [diff] [review]:
-----------------------------------------------------------------

Hooray for more SVGs!  Thanks, these changes look fine to me, and the results look good when I applied the patch and took a look.  I agree with Alex about doing more with calendar list UI in its own bug.

I think Geoff is working on a revamp of the attendees dialog, so it might be worth checking in with him about coordinating changes there.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: 1638863-calendar-SVG.patch

Replaced the checkbox in the calendar list with a eye icon. ui-r+ from aleca through Matrix.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: 1638863-calendar-SVG.patch

Forgot to qrefresh.

Comment 7

[Richard Marti (:Paenglab)]

I think it's about the textbox below not changing to dark and the vertical tabs staying white.

Comment 8

[Richard Marti (:Paenglab)]

Last comment doesn't belong to this bug.

Comment 9

[Paul Morris [:pmorris]]

Comment on attachment 9149933 [details] [diff] [review]
1638863-calendar-SVG.patch

Review of attachment 9149933 [details] [diff] [review]:
-----------------------------------------------------------------

r+ The eye icon looks good and works well when I tested it.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/16595a198a90
Calendar: convert more images to SVG. r=pmorris, ui-r=aleca

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42b043ac0ea0
follow-up - Clear removed files from the parsable CSS whitelist. rs=bustage-fix DONTBUILD