Closed Bug 163890 Opened 18 years ago Closed 7 years ago

editusers.cgi treats "_" (underscore) as a wildcard

Categories

(Bugzilla :: Administration, task, minor)

2.17
task
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: timeless, Assigned: sjoshi)

References

()

Details

Attachments

(1 file, 1 obsolete file)

load
http://bugzilla.mozilla.org/editusers.cgi?action=list&matchtype=substr&matchstr=dean_t
actual results:
Select user
 
Edit user ... Real name
dean.tessman@cancerboard.ab.ca Dean Tessman
deanstrickland@yahoo.com Brent
dean_tessman@hotmail.com Dean Tessman
mtdean@thirdcontact.com Michael T. Dean
4 users found.

expected results:
Select user
 
Edit user ... Real name
dean_tessman@hotmail.com Dean Tessman
1 users found.
Asummedly this is an SQL wildcard field ... probably standardisation on POSIX
regexps would be handy here.
No, this is because we're using sql LIKE stuff to simulate substr.... We should
use substr directly, instead
> No, this is because we're using sql LIKE stuff to simulate substr

I thought I said that.
Depends on: 119485
Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.
Assignee: justdave → administration
QA Contact: mattyt-bugzilla → default-qa
Attached patch Solved _(Underscore) Issue (obsolete) — Splinter Review
PLease assign this bug to me..i am not able to set review ? for this.
Thanks.!!
Assignee: administration → joshi_sunil
Attachment #639370 - Flags: review?(bugzilla.1.wurblzap)
Comment on attachment 639370 [details] [diff] [review]
Solved _(Underscore)  Issue

Thanks for the patch! Sorry for letting you wait so long.

I think that, while you're there, you should also escape the % sign.

Bugzilla currently supports MySQL, PgSQL, SQLite and Oracle. Are you sure the \ sign is the correct escape character for all those? (It may be, I just don't know.)
Attachment #639370 - Flags: review?(bugzilla.1.wurblzap) → review-
Attachment #639370 - Attachment is patch: true
Attached patch PatchSplinter Review
Attachment #661508 - Flags: review?(bugzilla.1.wurblzap)
Attachment #639370 - Attachment is obsolete: true
Attachment #661508 - Flags: review?(bugzilla.1.wurblzap) → review?(LpSolit)
Comment on attachment 661508 [details] [diff] [review]
Patch

r=LpSolit
Attachment #661508 - Flags: review?(LpSolit) → review+
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: approval4.4+
Flags: approval+
OS: Windows 2000 → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 4.4
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified editusers.cgi
Committed revision 8435.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified editusers.cgi
Committed revision 8424.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I'm sorry for letting you wait for review. Thanks, Frédéric, for picking this up.

(In reply to Marc Schumann [:Wurblzap] from comment #7)
> Bugzilla currently supports MySQL, PgSQL, SQLite and Oracle. Are you sure
> the \ sign is the correct escape character for all those? (It may be, I just
> don't know.)

Has this been cleared up?
You need to log in before you can comment on or make changes to this bug.