editusers.cgi treats "_" (underscore) as a wildcard

RESOLVED FIXED in Bugzilla 4.4

Status

()

Bugzilla
Administration
--
minor
RESOLVED FIXED
16 years ago
6 years ago

People

(Reporter: timeless, Assigned: sjoshi)

Tracking

2.17
Bugzilla 4.4
Bug Flags:
approval +
approval4.4 +

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

544 bytes, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

16 years ago
load
http://bugzilla.mozilla.org/editusers.cgi?action=list&matchtype=substr&matchstr=dean_t
actual results:
Select user
 
Edit user ... Real name
dean.tessman@cancerboard.ab.ca Dean Tessman
deanstrickland@yahoo.com Brent
dean_tessman@hotmail.com Dean Tessman
mtdean@thirdcontact.com Michael T. Dean
4 users found.

expected results:
Select user
 
Edit user ... Real name
dean_tessman@hotmail.com Dean Tessman
1 users found.
Asummedly this is an SQL wildcard field ... probably standardisation on POSIX
regexps would be handy here.
No, this is because we're using sql LIKE stuff to simulate substr.... We should
use substr directly, instead
> No, this is because we're using sql LIKE stuff to simulate substr

I thought I said that.

Updated

14 years ago
Depends on: 119485
Reassigning bugs that I'm not actively working on to the default component owner
in order to try to make some sanity out of my personal buglist.  This doesn't
mean the bug isn't being dealt with, just that I'm not the one doing it.  If you
are dealing with this bug, please assign it to yourself.
Assignee: justdave → administration
QA Contact: mattyt-bugzilla → default-qa
(Assignee)

Comment 5

6 years ago
Created attachment 639370 [details] [diff] [review]
Solved _(Underscore)  Issue
(Assignee)

Comment 6

6 years ago
PLease assign this bug to me..i am not able to set review ? for this.
Thanks.!!
Assignee: administration → joshi_sunil
(Assignee)

Updated

6 years ago
Attachment #639370 - Flags: review?(bugzilla.1.wurblzap)
Comment on attachment 639370 [details] [diff] [review]
Solved _(Underscore)  Issue

Thanks for the patch! Sorry for letting you wait so long.

I think that, while you're there, you should also escape the % sign.

Bugzilla currently supports MySQL, PgSQL, SQLite and Oracle. Are you sure the \ sign is the correct escape character for all those? (It may be, I just don't know.)
Attachment #639370 - Flags: review?(bugzilla.1.wurblzap) → review-

Updated

6 years ago
Attachment #639370 - Attachment is patch: true
(Assignee)

Comment 8

6 years ago
Created attachment 661508 [details] [diff] [review]
Patch
Attachment #661508 - Flags: review?(bugzilla.1.wurblzap)
(Assignee)

Updated

6 years ago
Attachment #639370 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #661508 - Flags: review?(bugzilla.1.wurblzap) → review?(LpSolit)

Comment 9

6 years ago
Comment on attachment 661508 [details] [diff] [review]
Patch

r=LpSolit
Attachment #661508 - Flags: review?(LpSolit) → review+

Updated

6 years ago
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: approval4.4+
Flags: approval+
OS: Windows 2000 → All
Hardware: x86 → All
Target Milestone: --- → Bugzilla 4.4

Comment 10

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified editusers.cgi
Committed revision 8435.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified editusers.cgi
Committed revision 8424.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I'm sorry for letting you wait for review. Thanks, Frédéric, for picking this up.

(In reply to Marc Schumann [:Wurblzap] from comment #7)
> Bugzilla currently supports MySQL, PgSQL, SQLite and Oracle. Are you sure
> the \ sign is the correct escape character for all those? (It may be, I just
> don't know.)

Has this been cleared up?
You need to log in before you can comment on or make changes to this bug.