1638991 - Convert 'mach telemetry-tests-client' to run with Python 3

Status: RESOLVED FIXED

(Toolkit :: Telemetry, task, P1)

Description

[Kris Wright :KrisWright]

mach telemetry-tests-client still runs with python 2 [1]. We want to convert all mach commands to python 3.

To do this, any dependencies of the command may need to be converted as well as the command itself.

[1] https://searchfox.org/mozilla-central/rev/9193635dca8cfdcb68f114306194ffc860456044/toolkit/components/telemetry/tests/marionette/mach_commands.py

Comment 1

[Raphael Aurich [:raphael] UTC+01:00]

We're blocked on Python 3 support in marionette driver.

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1638991 - Fix a couple Python 3 issues in telemetry-tests-client

Comment 3

[Andrew Halberstadt [:ahal]]

Once https://phabricator.services.mozilla.com/D108828 lands, this will be the last command to be converted :).

I took a stab at converting it, but the tests hit timeouts under Python 3 (with no obvious errors reported). Raphael, do you think you'll have a chance to look into this sometime soon? Are the timeouts what you were talking about in comment 1? And if so, who would be best to fix marionette driver? Thanks!

Comment 4

[Raphael Aurich [:raphael] UTC+01:00]

I am currently testing D108834 locally. When I run ./mach telemetry-tests-client the imports seem to be resolved just fine, but the browser hangs and the test suite eventually fails with the following error:

IOError: Process killed after 120s because no connection to Marionette server could be established. Check gecko.log for errors

The gecko.log file contains the following lines, which I can't seem to find on a recent central checkout:

1616075482644	Marionette	INFO	Listening on port 2828
1616075482682	Toolkit.Telemetry	TRACE	TelemetryController::observe - app-startup notified.
JavaScript error: chrome://marionette/content/driver.js, line 136: NS_ERROR_FILE_NOT_FOUND:

Comment 5

[Raphael Aurich [:raphael] UTC+01:00]

I rebased patch D108834 locally to a recent a central checkout and all 9 tests passed via python2 ./mach telemetry-tests-client.

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1638991 - [telemetry-tests-client] Ensure wptserve logs are included in our logger, r?raphael

Comment 7

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1638991 - [telemetry-tests-client] Green up the tests on Python 3, r?raphael

Depends on D109080

Comment 8

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1638991 - [mach] Run ./mach telemetry-tests-client with Python 3, r?raphael

Depends on D109081

Comment 9

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1638991 - [ci] Run telemetry-tests-client tests with Python 3, r?raphael

Comment 10

[Phabricator Automation]

Comment on attachment 9210321 [details]
Bug 1638991 - [ci] Run telemetry-tests-client tests with Python 3, r?raphael

Revision D109084 was moved to bug 1699757. Setting attachment 9210321 [details] to obsolete.

Comment 11

[Raphael Aurich [:raphael] UTC+01:00]

Clearing the ni request here since we're discussing on the Phabricator patches.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92a28262af54
[telemetry-tests-client] Ensure wptserve logs are included in our logger, r=raphael
https://hg.mozilla.org/integration/autoland/rev/f91acacf9df7
[telemetry-tests-client] Green up the tests on Python 3, r=raphael
https://hg.mozilla.org/integration/autoland/rev/cbdac2bc544f
[mach] Run ./mach telemetry-tests-client with Python 3, r=raphael

Comment 13

[Andrew Halberstadt [:ahal]]

Attachment: WIP: Bug 1638991 - [telemetry-tests-client] Don't use relative imports in telemetry_harness

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfe565378798
WIP: Bug 1638991 - [telemetry-tests-client] Don't use relative imports in telemetry_harness. CLOSED TREE

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/92a28262af54
https://hg.mozilla.org/mozilla-central/rev/f91acacf9df7
https://hg.mozilla.org/mozilla-central/rev/cbdac2bc544f
https://hg.mozilla.org/mozilla-central/rev/cfe565378798