163905 - [typeaheadfind] F3 hangs browser after selection returns to normal color

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Aaron Leventhal]

Pressing F3 causes Mozilla to lock up, unless typeaheadfind is active.

This brought to light another mistake - when the user types in incorrect
character, typeaheadfind should still add the character to the buffer, so the
user can press backspace.

Comment 1

[Aaron Leventhal]

Attachment: Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

Seeking r=

Comment 2

[:deanis74]

> This brought to light another mistake - when the user types in incorrect
> character, typeaheadfind should still add the character to the buffer, so the
> user can press backspace.

Really?  That's not how Delphi's incremental search works and I quite like it
that way.

Comment 3

[Aaron Leventhal]

Well there's an #ifdef there at the moment. It's a small polish thing that we
can change, depending on what the majority goes for. I happen to agree, I think
bad characters shouldn't get added to the buffer.

Comment 4

[Kyle Yuan]

Comment on attachment 96201 [details] [diff] [review]
Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

r=kyle

Comment 5

[Alec Flett]

Comment on attachment 96201 [details] [diff] [review]
Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

isn't sound a service, not a createinstance? 
with GetService, sr=alecf

Comment 6

[Aaron Leventhal]

It doesn't appear to be a GetService - every where I look it's using
do_CreateInstance().

Comment 7

[Alec Flett]

ah, I see.. that's because it CAN be used for asynchronous playing of sound
files... this is a whole other issue :)
sr=alecf with or without it.

Comment 8

[Aaron Leventhal]

checked in.

Comment 9

[David Brittain]

verified fixed with 2002082608 on windows 2000