[typeaheadfind] F3 hangs browser after selection returns to normal color

VERIFIED FIXED

Status

SeaMonkey
Find In Page
--
critical
VERIFIED FIXED
16 years ago
9 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

({hang})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Pressing F3 causes Mozilla to lock up, unless typeaheadfind is active.

This brought to light another mistake - when the user types in incorrect
character, typeaheadfind should still add the character to the buffer, so the
user can press backspace.
(Assignee)

Comment 1

16 years ago
Created attachment 96201 [details] [diff] [review]
Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

Seeking r=
(Assignee)

Updated

16 years ago
Blocks: 30088

Updated

16 years ago
Severity: normal → critical
Keywords: hang

Comment 2

16 years ago
> This brought to light another mistake - when the user types in incorrect
> character, typeaheadfind should still add the character to the buffer, so the
> user can press backspace.

Really?  That's not how Delphi's incremental search works and I quite like it
that way.
(Assignee)

Comment 3

16 years ago
Well there's an #ifdef there at the moment. It's a small polish thing that we
can change, depending on what the majority goes for. I happen to agree, I think
bad characters shouldn't get added to the buffer.

Comment 4

16 years ago
Comment on attachment 96201 [details] [diff] [review]
Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

r=kyle
Attachment #96201 - Flags: review+

Comment 5

16 years ago
Comment on attachment 96201 [details] [diff] [review]
Fixes issues with removal of characters from buffer upon failure, thus correcting bug and other minor problems

isn't sound a service, not a createinstance? 
with GetService, sr=alecf
Attachment #96201 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
It doesn't appear to be a GetService - every where I look it's using
do_CreateInstance().

Comment 7

16 years ago
ah, I see.. that's because it CAN be used for asynchronous playing of sound
files... this is a whole other issue :)
sr=alecf with or without it.
(Assignee)

Comment 8

16 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 9

16 years ago
verified fixed with 2002082608 on windows 2000
Status: RESOLVED → VERIFIED

Updated

15 years ago
Component: Keyboard: Navigation → Keyboard: Find as you Type
Product: Core → SeaMonkey
You need to log in before you can comment on or make changes to this bug.