1639111 - Devtools actor errors using Components.exception show as unknownError

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

Spotted while investigating Bug 1637687. The DevTools push-subscription actor was calling a getter which was throwing with

Components.Exception("", Cr.NS_ERROR_NOT_IMPLEMENTED);

and the only error visible in the client was unknownError from: server0.conn7.serviceWorkerRegistration37

We could improve this slightly, and maybe add the filename, linenumber, columnnumber to the error packet to improve this even further.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1639111 - Fallback on error.name in DevTools actor error handling

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1639111 - Show the filename, line and column for DevTools actor errors

Depends on D75902

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55df4479027c
Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
https://hg.mozilla.org/integration/autoland/rev/7ca3266213e7
Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_preference.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/5e78c6238e348639fdbd0bd47eb2151aadd66bee
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303599266&repo=autoland&lineNumber=99497

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84be772b9ac4
Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
https://hg.mozilla.org/integration/autoland/rev/2964f445c2f5
Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau

Comment 6

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (bug 1639111) for causing failures in browser_actor_error.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/6ca2b4a6bbf8cc1b9b58a0255e482acd14369c98

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=2964f445c2f53b8eb091e23d51486dd12202c52f&selectedTaskRun=eGuVoSslQiyPWiuIujxltA-0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303631422&repo=autoland&lineNumber=14700

Comment 7

[Alexandru Michis [:malexandru]]

Also looks to be causing some more failures in test_preference.html:
https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=%28c%2Cmochitest&tochange=e7641c1071eaadf8a74fc16c13456d4d63b367d0&fromchange=be7a56eeccc3a8e70dffd4f419b090ad4d44f651&selectedTaskRun=X073qmzOTQyKMBoh_hZHMQ-0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a1167da068
Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
https://hg.mozilla.org/integration/autoland/rev/0b15f53e5fc7
Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a8a1167da068
https://hg.mozilla.org/mozilla-central/rev/0b15f53e5fc7