Closed Bug 1639122 Opened 2 months ago Closed 1 month ago

Compat panel - add padding between browser icons and issue type

Categories

(DevTools :: Inspector: Compatibility, enhancement, P3)

enhancement

Tracking

(firefox77 wontfix, firefox78 wontfix, firefox79 verified)

VERIFIED FIXED
Firefox 79
Tracking Status
firefox77 --- wontfix
firefox78 --- wontfix
firefox79 --- verified

People

(Reporter: cfogel, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Affected versions

  • 77.0b7(DevTools), 78.0a1 (2020-05-18)

Affected platforms

  • macOS 10.15.4, Windows 10, Ubuntu 18.04;

Steps to reproduce

  • devtools.inspector.compatibility.enabled preff on true;
  1. Launch Firefox, open DevTools Inspector - Compat tab;
  2. Access about:newtab
  3. Wait until the list populates with issues, expand sections;
  4. Expand the nested lists in the Compat tab;

Expected result

  • UI properly displayed

Actual result / Enhancement suggestion

  • for experimental/deprecated or lists with multiple browsers padding between the text and icons is needed - otherwise they're sticking one to the other in certain size scenarios

Regression range

  • not a regression;

Additional notes

  • attached screenshot to illustrate the issue.
Has STR: --- → yes

Related to padding - could we increase the gap between icons to 6px?

^ This one is pretty visible in screenshots/demos so I would rate it a higher priority :)

Priority: -- → P3
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Oh, I landed the patch with thinking that this is bug 1639495..
However, this patch would fix three bugs include the above bug at the same time.

  • Bug 1639122 - Compat panel - add padding between browser icons and issue type (this bug)
  • Bug 1639495 - Compat panel - keep bottom scrollbar in view if needed
  • Bug 1639194 - Compat panel - issues separators not drawn over the whole section
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ae23d137681
Make issue item components collapsable. r=ladybenko
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Blocks: 1639495, 1639194
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.