1639128 - Bugzilla labels missing with Template::Toolkit v3.008

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Thomas Reinke]

Attachment: defectfiles.tgz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Building any of BugZilla 4.4.9 up to and including 5.0.6 will produce a functioning system where the various pages are missing the descriptive text for fields the user needs to enter. The problem occurs when the install-module.pl convenience script is used to install requisite perl modules, and ends up picking up Template::Toolkit v3.008. If one uses an older version (such as version 2.24 which is what is in the Debian 9 repository), the problem goes away and all fields across the site are displayed clearly. Guessing probable cause is a regression introduced recently via Template::Toolkit v3.008.

Re https://groups.google.com/forum/#!topic/mozilla.support.bugzilla/q4_4t1BBmic

As per Thorsten's guidance - am attaching both the create.html.tmpl and field-descs.none.tmpl generated files for both versions of the toolkit, along with a screenshot of the enter_bug.cgi page and what it looks like with the missing labels inte the attached defectfiles.tgz.

Actual results:

Descriptive labels that one can hover over to get help text on are shown as only a ":".

Expected results:

Descriptive labels should appear.

Comment 1

[Thorsten Schöning]

Just want to mention that different bugs address different issues with Template::Toolkit as well and discuss bumping the required version. Should make sense to have the root cause of this problem found before doing so to not break more than necessary. :-)

Upgrading Template-Toolkit to at least 3.000 fixes the problem. Maybe it's time to increase the minimum required version for this module, to work with newer versions of perl (master only, to not break current 5.0.x installations).

https://bugzilla.mozilla.org/show_bug.cgi?id=1625554#c2

Comment 2

[lukaszp]

This issue is related to a bug in Template Toolkit v3.008 which was reported to TT Issue tracker https://github.com/abw/Template2/issues/263

Comment 3

[Frédéric Buclin]

I can confirm this bug too. We had the same problem with Mageia Bugzilla using TT 3.008. This is a regression in TT 3.008 and I can confirm that this bug is fixed in TT 3.009 (I tested it a few minutes ago). justdave, please blocklist this version too and bump the min version to 3.009.

https://bugs.mageia.org/show_bug.cgi?id=33660#c16

It's a pity this bug has not been caught on time for 5.2 and 5.0.4.1. Marking it as a blocker for 5.2.1 and 5.0.4.2

Comment 4

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] [5.0.4] Bug 1639128: Blocklist Template 3.008 (#220)

Comment 5

[BMO Github Automation]

Attachment: [bugzilla/bugzilla] [5.2] Bug 1639128: Require Template >=3.009 (#221)

Comment 6

[BMO Github Automation]

Attachment: [bugzilla/harmony] [harmony] Bug 1639128: Require Template >=3.009 (#155)

Comment 7

[Frédéric Buclin]

Comment on attachment 9600170 [details] [review]
[bugzilla/bugzilla] [5.0.4] Bug 1639128: Blocklist Template 3.008 (#220)

r=LpSolit for 5.0.4

Comment 8

[Frédéric Buclin]

Comment on attachment 9600171 [details] [review]
[bugzilla/bugzilla] [5.2] Bug 1639128: Require Template >=3.009 (#221)

r=LpSolit

Comment 9

[Dave Miller [:justdave]]

Comment on attachment 9600171 [details] [review]
[bugzilla/bugzilla] [5.2] Bug 1639128: Require Template >=3.009 (#221)

Landed on 5.2:
https://github.com/bugzilla/bugzilla/commit/4cc05c58a5f1b5f3de72a2a7b1090526da9a275c

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 9600170 [details] [review]
[bugzilla/bugzilla] [5.0.4] Bug 1639128: Blocklist Template 3.008 (#220)

Landed on 5.0.4:
https://github.com/bugzilla/bugzilla/commit/972ee348492a7b2f99a87c7474ff24bae989a2a0

Comment 11

[Dave Miller [:justdave]]

Comment on attachment 9600172 [details] [review]
[bugzilla/harmony] [harmony] Bug 1639128: Require Template >=3.009 (#155)

Landed on harmony:
https://github.com/bugzilla/harmony/commit/f6ee984b51ac2787abb8721b11c5f1eeed0cd4b8