1639173 - The "Learn More" (i) option from the import suggestion dropdown is not reachable via keyboard only navigation

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: info button is not reachable with keyboard only navigation.gif

[Affected versions]:

• Firefox Nightly 78.0a1, BuildID 20200518214824
• Firefox Beta 77.0b7, BuildID 20200515125749

[Affected Platforms]:

• All Windows
• All Mac

[Prerequisites]:

• Have a clean new profile with no saved or imported logins.
• Have the following prefs set to the following values:
  • signon.showAutoCompleteImport set to import
• Have a couple of logins saved in either Chrome or Edge (chromium)

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites and navigate to a website that has a saved login in Chrome/Edge.
2. Focus the username filed.
3. Press the Down Arrow key twice.
4. Press the Enter key and observe the behavior.

[Expected results]:

• The https://support.mozilla.org/en-US/kb/import-data-another-browser?as=u&utm_source=inproduct page is opened.

[Actual results]:

• The about:logins page is opened.

[Additional Notes]:

• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

P3 for the experiment although long term if we ship this feature, I wonder if this is why there usually(?) isn't extra clickable targets on autocomplete items. There isn't really moving focus when selecting autocomplete suggestions as the focus stays in the text box but the visually highlighted item does happen to update.

Comment 2

[Ed Lee :Mardak]

Attachment: 3 importable and 1 learn more item

Here's a potential fix where instead of having special keyboard interactions within an autocomplete popup, we put the "learn more" as a separate item that has normal keyboard interactions.

Comment 3

[Ed Lee :Mardak]

Attachment: adjusted with ux feedback

Comment 4

[Ed Lee :Mardak]

Attachment: Bug 1639173 - Replace import info icon with Learn More autocomplete entry r?MattN

When adding importable logins, also add new single row autocomplete entry with fluent text and ignore it for telemetry.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/116fb4dddc04
Replace import info icon with Learn More autocomplete entry r=MattN,fluent-reviewers,flod

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/116fb4dddc04

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible on the latest Beta 81.0b1 (BuildID 20200824150741) and the latest Nightly 82.0a1 (BuildID 20200824215021) using Windows 10 and macOS 10.15.4.