1639262 - StyleSheet cache over-reports memory.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1639262 - Avoid duplicate entries in the stylesheet cache. r=nordzilla,#style

When the loader finds an already-complete stylesheet, it will call
PostLoadEvent to fire the load event of the relevant <link> element,
etc.

For that, it'll mint a SheetLoadData, with various fields hard-coded.
That causes us to eventually insert the sheet in mCompleteSheets, but
with a different key, which means we'll end up with two copies of the
same stylesheet in the cache, than when reporting memory we'll report
twice.

Fix it by constructing the right load data a bit sooner, and add an
assertion to ensure this doesn't happen anymore.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1639262 - Get the right "is preload" value to CreateSheet. r=mayhemer

This could also cause mismatches in the cache for no good reason.

Depends on D76000

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf1939b293d9
Avoid duplicate entries in the stylesheet cache. r=nordzilla,firefox-style-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/191820bda8f5
Get the right "is preload" value to CreateSheet. r=nordzilla

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/cf1939b293d9
https://hg.mozilla.org/mozilla-central/rev/191820bda8f5