1639398 - VRManager allocated in every process even though it can't be accessed

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Andrew McCreight [:mccr8]]

I was looking through a DMD report for a content process, and one of the unreported blocks was something that looks like VRManager. This structure is quite large, about 77,824 bytes. Also, VRManager::Get() asserts if it is called in a process that isn't either the parent process or the GPU process, so we shouldn't allocate it except in those processes.

Comment 1

[Daosheng Mu[:daoshengmu]]

Yes. You are right, we need fix it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:kip, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Bug 1639398 - Only create VRManager in processes where it can be used.

This avoids about 77kb of content process overhead.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2f38d6f5b44
Only create VRManager in processes where it can be used. r=daoshengmu,kip

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f2f38d6f5b44

Comment 6

[Florin Strugariu [:Bebe]]

== Change summary for alert #26168 (as of Tue, 09 Jun 2020 12:16:31 GMT) ==

Improvements:

5% Base Content Heap Unclassified windows10-64-shippable opt 1,641,355.67 -> 1,564,418.00
5% Base Content Heap Unclassified windows10-64-shippable opt 1,632,308.00 -> 1,557,502.67

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26168