1639406 - [Automated review] Reviewbot generated patch is missing a leading slash in the name of the file

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Anny Gakhokidze [:annyG]]

Phabricator URL: https://phabricator.services.mozilla.com/D72745#2315436

Reviewbot generated the following patch for me https://firefoxci.taskcluster-artifacts.net/AWBlbaihQ-SVxzAGPNX-jw/0/public/patch/source-test-clang-format-PHID-DIFF-ghkutvo7yjuwjv2d7ohl.diff however the location of the file is missing a leading / and I am unable to apply the patch locally until I add a leading / in front of dom.

I use git locally.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Andi [:andi]]

Thank you for reporting this! I think there are two things that are missing here, the a/ and the /b from the original and modified versions.

Comment 3

[Andi [:andi]]

Attachment: Bug 1639406 - for `code-review` generate the propper patch when dealing with `clang-format` issues. r=marco

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ecc718f88e0
for `code-review` generate the propper patch when dealing with `clang-format` issues. r=marco

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/3ecc718f88e0