Closed Bug 1639406 Opened 2 months ago Closed 1 month ago

[Automated review] Reviewbot generated patch is missing a leading slash in the name of the file

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: annyG, Assigned: andi)

Details

Attachments

(1 file)

Phabricator URL: https://phabricator.services.mozilla.com/D72745#2315436

Reviewbot generated the following patch for me https://firefoxci.taskcluster-artifacts.net/AWBlbaihQ-SVxzAGPNX-jw/0/public/patch/source-test-clang-format-PHID-DIFF-ghkutvo7yjuwjv2d7ohl.diff however the location of the file is missing a leading / and I am unable to apply the patch locally until I add a leading / in front of dom.

I use git locally.

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bpostelnicu)

Thank you for reporting this! I think there are two things that are missing here, the a/ and the /b from the original and modified versions.

Flags: needinfo?(bpostelnicu) → needinfo?(agakhokidze)
Flags: needinfo?(agakhokidze)
Assignee: nobody → bpostelnicu
Status: NEW → ASSIGNED
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ecc718f88e0
for `code-review` generate the propper patch when dealing with `clang-format` issues. r=marco

The severity field is not set for this bug.
:andi, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(bpostelnicu)
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Severity: -- → S2
Flags: needinfo?(bpostelnicu)
You need to log in before you can comment on or make changes to this bug.