1639496 - Translate vCard 2.1 into a newer version before trying to parse

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Geoff Lankow (:darktrojan)]

Some implementations (including Thunderbird, up until a few minutes ago; also Android, at least on my phone) export contacts as vCard 2.1, but ICAL.js doesn't parse that version. We'll translate as much as we can to a newer version so that we can still import it.

We'll need to change property names such as TEL;WORK to TEL;TYPE=work for example, and I think we'll also need to change quoted-printable encoding into UTF-8, if I recall the spec correctly.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1639496-vcard21-1.diff

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9154105 [details] [diff] [review]
1639496-vcard21-1.diff

Review of attachment 9154105 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I wonder if/what parts of this really should be in ical.js

Comment 3

[Geoff Lankow (:darktrojan)]

There is a PR on ical.js to support 2.1, but it seems to have stalled and we're unlikely to get a new version from upstream by release anyway.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eb8a7df0f79c
Translate vCard 2.1 into a newer version before trying to parse. r=mkmelin

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9154105 [details] [diff] [review]
1639496-vcard21-1.diff

Approved for beta

Comment 6

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/46a97dfc01e5