1639533 - Fix invalid assumption in invalidation after bug 1632647

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

Bug 1632647 allows us to do stuff like: ::-moz-range-thumb:is(:hover), and that trips one assumption during invalidation.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1639533 - Fix a no-longer valid assumption in pseudo-element matching / invalidation code. r=#style

After bug 1632647, we can have pseudo-classes inside :not / :is /
:where, which the invalidation and matching code weren't handling.

Add a few tests for this stuff working as expected.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1639533 - Fix a case where we'd allow parsing functional :host incorrectly. r=#style

This is a missing check I should've introduced in bug 1632647.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b87e7b47c38
Fix a case where we'd allow parsing functional :host incorrectly. r=heycam
https://hg.mozilla.org/integration/autoland/rev/23ddff9da376
Fix a no-longer valid assumption in pseudo-element matching / invalidation code. r=heycam

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23721 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/7b87e7b47c38
https://hg.mozilla.org/mozilla-central/rev/23ddff9da376

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot