1639552 - Use a CipherStrategy for IndexedDB SQLite databases in private browsing mode

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, enhancement, P2)

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Export SQLite symbols required by ObfuscatingVFS.

Disable test cases failing with SQLite 3.32.0.

DO NOT LAND THIS!

This should be done in the context of Bug 1619522 instead.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Add obfuscating VFS.

Depends on D76139

Comment 3

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Integrate IPCStreamCipherStrategy into ObfuscatingVFS.

Depends on D76140

Comment 4

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Register ObfuscatingVFS.

Depends on D76141

Comment 5

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Use ObfuscatingVFS if a URL containing a key is specified.

Depends on D76147

Comment 6

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Integrate SQLite encryption in private browsing mode.

Depends on D76172

Comment 7

[Marco Bonardo [:mak]]

Is this ok to have in 79, after the merge (note 78 is an ESR)? Asking also regarding bug 1619522

Comment 8

[Simon Giesecke [:sg] [he/him]]

Sure, it doesn't need to get into 78.Same goes for Bug 1619522 as far as IndexedDB is concerned AFAIU. (Note that IndexedDB private browsing mode won't ride the train to release anyway, even when it lands in Nightly)

Comment 9

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Fix remaining clang-tidy diagnostics in ObfuscatingVFS. r=sylvestre

Depends on D76173

Comment 10

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1639552 - Use NS_WARNING instead of sqlite3_log. r=#dom-workers-and-storage

Depends on D94576

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d04efeaaa8
Export SQLite symbols required by ObfuscatingVFS. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/b6dc5a2fbd2d
Add obfuscating VFS. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/b7ff2da4706b
Integrate IPCStreamCipherStrategy into ObfuscatingVFS. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/2696dc0a1292
Register ObfuscatingVFS. r=dom-workers-and-storage-reviewers,mak,janv
https://hg.mozilla.org/integration/autoland/rev/38d90ab9f206
Use ObfuscatingVFS if a URL containing a key is specified. r=dom-workers-and-storage-reviewers,mak,janv
https://hg.mozilla.org/integration/autoland/rev/2956763576b4
Integrate SQLite encryption in private browsing mode. r=dom-workers-and-storage-reviewers,janv
https://hg.mozilla.org/integration/autoland/rev/ae14b94d8726
Fix remaining clang-tidy diagnostics in ObfuscatingVFS. r=sylvestre,janv
https://hg.mozilla.org/integration/autoland/rev/d7a70f3f59e7
Use NS_WARNING instead of sqlite3_log. r=dom-workers-and-storage-reviewers,janv

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/67d04efeaaa8
https://hg.mozilla.org/mozilla-central/rev/b6dc5a2fbd2d
https://hg.mozilla.org/mozilla-central/rev/b7ff2da4706b
https://hg.mozilla.org/mozilla-central/rev/2696dc0a1292
https://hg.mozilla.org/mozilla-central/rev/38d90ab9f206
https://hg.mozilla.org/mozilla-central/rev/2956763576b4
https://hg.mozilla.org/mozilla-central/rev/ae14b94d8726
https://hg.mozilla.org/mozilla-central/rev/d7a70f3f59e7