Closed Bug 1639563 Opened 2 months ago Closed 1 month ago

Sanitize fonts before we use them

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

(Regressed 1 open bug)

Details

(Whiteboard: wr-planning)

Attachments

(5 files)

No description provided.
Assignee: nobody → lsalzman

Is this referring to webfonts, or to all fonts including platform-installed ones? Curious what the motivation is here, given that we already sanitize webfont resources on download.

We need to resanitize webfonts that we get from the content process because it may have been compromised.

Whiteboard: wr-planning

Depends on D76358

Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43abf0a9602a
factor out gfxOTSContext into reusable header file. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/b2c8de065886
sanitize WR fonts. r=jrmuizel
Backout by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d2f5e8bb67e
Backed out 2 changesets for gfx related bustages CLOSED TREE

Backed out 2 changesets (bug 1639563) for gfx related bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Cdebug%2Cbuild-linux64-base-toolchains%2Fdebug%2C%28bb%29&fromchange=0261162195643a968c73bdeffa0d8db3bfd38aec&selectedTaskRun=cFaTmtiaRd-yvhhAo1AGMw-0&tochange=99a82cb34de1fb50533829a271506d94da191744

Backout link: https://hg.mozilla.org/integration/autoland/rev/3d2f5e8bb67eb2a6c11f64bc6096f6f5a9f4a737

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303311055&repo=autoland&lineNumber=23207

[task 2020-05-22T01:41:00.046Z] 01:41:00     INFO -  ../../gcc-source/gcc/cp/parser.c:11052
[task 2020-05-22T01:41:00.046Z] 01:41:00     INFO -  Please submit a full bug report,
[task 2020-05-22T01:41:00.046Z] 01:41:00     INFO -  with preprocessed source if appropriate.
[task 2020-05-22T01:41:00.046Z] 01:41:00     INFO -  Please include the complete backtrace with any bug report.
[task 2020-05-22T01:41:00.046Z] 01:41:00     INFO -  See <https://gcc.gnu.org/bugs/> for instructions.
[task 2020-05-22T01:41:00.047Z] 01:41:00     INFO -  /builds/worker/checkouts/gecko/config/rules.mk:746: recipe for target 'Unified_cpp_gfx_thebes1.o' failed
[task 2020-05-22T01:41:00.047Z] 01:41:00    ERROR -  make[4]: *** [Unified_cpp_gfx_thebes1.o] Error 1
[task 2020-05-22T01:41:00.047Z] 01:41:00     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/thebes'
[task 2020-05-22T01:41:00.047Z] 01:41:00     INFO -  /builds/worker/checkouts/gecko/config/recurse.mk:74: recipe for target 'gfx/thebes/target-objects' failed
[task 2020-05-22T01:41:00.047Z] 01:41:00    ERROR -  make[3]: *** [gfx/thebes/target-objects] Error 2
[task 2020-05-22T01:41:00.047Z] 01:41:00     INFO -  make[3]: *** Waiting for unfinished jobs....
Flags: needinfo?(lsalzman)

Okay, patch in autoland queue to fix the GCC internal compiler error...

Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3391ec4e90a5
factor out gfxOTSContext into reusable header file. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/adde6fa9b4d6
sanitize WR fonts. r=jrmuizel
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b4e5fe79094
fix GCC internal compiler error. r=jfkthame
Regressions: 1640401
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ddf302b8b8a9
make WROTSAlloc::Grow check capacity instead of length. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/fc9af2e86dbd
add some warnings when fonts fail to sanitize. r=jrmuizel
Regressions: 1640656
Blocks: 1641951
You need to log in before you can comment on or make changes to this bug.