1639577 - GV:OnLoadRequest with empty uri when pressing the paypal button

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Petru-Mugurel Lingurar [:petru]]

First reported on Fenix a few months ago in https://github.com/mozilla-mobile/fenix/issues/4918 but also reproducible in geckoview-example for which I'll post some logs.

The issue seems to relate to newly opened pages which would ask users to login.
Seems to be a relatively recent regression resulting in some kind of a race since me and others have got to the expected result when debugging with breakpoints.

ESR geckoview_example working:

• video - https://drive.google.com/file/d/1fYFSthrDHTg0Idsnk4mJiCn1eeN3SQkg/view?usp=sharing
• logs - https://pastebin.com/Q705JG8z

Latest geckoview_example not working:

• video - https://drive.google.com/file/d/1rnVQW7HxnGjD9AlzUaVNsypJwbM8kICZ/view?usp=sharing
• logs - https://pastebin.com/X7KKa5p8

Comment 1

[Emily Toop (:fluffyemily)]

Possibly related to bug 1644596

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

This looks like it has been broken for a long time, can't make it work on 75 onward. On 72 it breaks in a different way.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

It appears that this is caused by us calling suspendTimeouts()[1] on the original page when it is backgrounded. Presumably the paypal page has to communicate with the original page via window.opener, and that's unable to occur if we suspend it. Maybe we could avoid suspending if we know it is used as window.opener elsewhere?

[1] https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContentChild.js#291

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1639577 - Only suspend GeckoView tabs that are alone in their BrowsingContextGroup

This avoids problems where a foreground tab tries to communicate with a background
tab via window.opener, but is unable to because the background tab
is suspended.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0073e006a287
Only suspend GeckoView tabs that are alone in their BrowsingContextGroup r=nika,geckoview-reviewers,agi

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0073e006a287