163961 - Lots of 'malformed url' warnings on startup

Status: VERIFIED WORKSFORME

(Core :: Networking, defect)

Description

[Simon Fraser [no longer active]]

I see lots of these:

WARNING: malformed url: no scheme, file nsStandardURL.cpp, line 736

at startup. They come out of a call in nsWebShell::NormalizeURI() which looks 
like:

  // clear out the old spec, for security reasons - old data should
  // not be floating around in cached URIs!
  // (but avoid doing extra work if we're just destroying the uri)
  if (clearUri)
    uri->SetSpec(NS_LITERAL_CSTRING(""));

Comment 1

[Simon Fraser [no longer active]]

Attachment: Patch; bails if spec is nil or empty string

Comment 2

[Alec Flett]

I fixed this like 8 hours after I checked in... you're still seeing it? update
netwerk/base/src/nsStandardURL.cpp again - make sure that these lines exist:

http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsStandardURL.cpp#1035

Those should prevent ParseURL from ever being called.

Comment 3

[Alec Flett]

wow yeah in fact your patch is EXACTLY what is in the tree. I'm marking this
worksforme.

Comment 4

[timeless]

wow, i suck, i knew about this, i just forgot the punchline. sorry all. 
vrfy: blame timeless

Comment 5

[Simon Fraser [no longer active]]

My tree is old. Sorry.