1639641 - Fallback from UnicodeEncodeError in jstests

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303110159&repo=mozilla-central&lineNumber=57960

[task 2020-05-20T16:01:12.255Z] Traceback (most recent call last):
[task 2020-05-20T16:01:12.255Z]   File "/builds/worker/workspace/build/src/js/src/tests/jstests.py", line 676, in <module>
[task 2020-05-20T16:01:12.256Z]     sys.exit(main())
[task 2020-05-20T16:01:12.256Z]   File "/builds/worker/workspace/build/src/js/src/tests/jstests.py", line 624, in main
[task 2020-05-20T16:01:12.256Z]     results.push(out)
[task 2020-05-20T16:01:12.256Z]   File "/builds/worker/workspace/build/src/js/src/tests/lib/results.py", line 296, in push
[task 2020-05-20T16:01:12.257Z]     self.fp.write(output.err)
[task 2020-05-20T16:01:12.257Z] UnicodeEncodeError: 'ascii' codec can't encode character '\u0e86' in position 75: ordinal not in range(128)

jsparagus doesn't escape unciode characters in the output, and it caused the failure in harness.
while jsparagus should escape it, the test harness should be robust against such output.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1639641 - Try fallback for printing stdout/stderr in jstests. r?sfink!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5032fce072a4
Try fallback for printing stdout/stderr in jstests. r=sfink

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5032fce072a4