Closed Bug 1639683 Opened 9 months ago Closed 9 months ago

fix the OpenPGP code that repairs broken messages from Exchange

Categories

(MailNews Core :: Security: OpenPGP, defect)

Product:
MailNews Core
Component:
Security: OpenPGP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 78.0

People

(Reporter: KaiE, Assigned: KaiE)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1639683 - Fix the OpenPGP code that repairs broken messages from Exchange. r=PatrickBrunschwig
47 bytes, text/x-phabricator-request
Details | Review

happened when saving an attachment

enigmailMessengerOverlay.js: messageDecryptCb: caught exception: TypeError
Message: 'can't access property "removeAttribute", ebeb is null'
File:    chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js
Line:    1194
Stack:   updateSecurityStatus@chrome://openpgp/content/ui/enigmailMsgHdrViewOverlay.js:1194:9
buggyMailHeader@chrome://openpgp/content/ui/enigmailMessengerOverlay.js:1048:33
messageDecryptCb@chrome://openpgp/content/ui/enigmailMessengerOverlay.js:973:16
messageDecrypt/<@chrome://openpgp/content/ui/enigmailMessengerOverlay.js:693:24
onData@chrome://openpgp/content/modules/mime.jsm:459:19
newStringStreamListener/onStopRequest/<@chrome://openpgp/content/modules/streams.jsm:78:17
callbackWrapper@chrome://openpgp/content/modules/timer.jsm:30:7
notify@resource://gre/modules/Timer.jsm:62:17
Attached patch 1639683-v1.patch (obsolete) — — Splinter Review

The error message is my own fault, because I haven't yet adjusted the code that attempts to repair broken messages from Exchange.
It attempts to access UI elements that I haven't added.

While testing the repair functionality, I noticed that it no longer works.
It took me a while to find the bug. This attachment fixes the repairing for me.
(But it doesn't yet fix the UI situation.)

Maybe we can have the same kind of notification bar with a button that I recently added for other situations, until we have a better solution for these kinds of interactions.

Patrick, when the code repairs a message, is that a permanent change on the IMAP server, and the original is lost after the repair?

Summary: messageDecryptCb: caught exception: TypeError Message: 'can't access property "removeAttribute", ebeb is null' → fix the OpenPGP code to repair broken messages from Exchange
Summary: fix the OpenPGP code to repair broken messages from Exchange → fix the OpenPGP code that repairs broken messages from Exchange
Attachment #9152205 - Attachment is obsolete: true

Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/8a2e074a410b
Fix the OpenPGP code that repairs broken messages from Exchange. r=PatrickBrunschwig

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/d937493550f5
Follow up to fix lint. rs=bustage DONTBUILD
Target Milestone: --- → Thunderbird 78.0
You need to log in before you can comment on or make changes to this bug.