1639820 - `moz-phab submit` should do `moz-phab reorg` if needed (or warn) to fix related parent/child links

Status: NEW

(Conduit :: moz-phab, enhancement, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

When adding patches in an existing stack, moz-phab submit correctly shows them as ( New) before submitting, but in Phabricator the stack is not properly reorganized, so some patches link to their old parent, which in particular confuses reviewbot.

I've only just learned about moz-phab reorg! (While filing this bug.)

Since moz-phab submit knows that some patches are new, it would be nice if it could automatically handle the reorg while submitting, or at least warn about it and suggest running moz-phab reorg so people know about this tool.

Comment 1

[Piotr Zalewa [:zalun]]

A warning with a piece of advice is a good idea.
Implement the reorg to the submit makes stack preparation a much longer process.

At the moment the process of changing the stack order is a bit complicated.
New revisions are fine as long as these are at the end of the stack.
If commits changed the order and a new commit appeared inside of the stack:

1. Submit new commits with a --single option
2. Reorganize moz-phab reorg