Closed Bug 1639823 Opened 5 years ago Closed 5 years ago

[macOS] Printing local pages fails with printSettings is null

Categories

(Core :: Printing: Setup, defect)

All
macOS
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- verified

People

(Reporter: emilghitta, Assigned: nordzilla)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [print2020_v78])

Affected versions

  • Firefox 76.0.1 (BuildId:20200507114007)
  • Firefox 77.0b8 (BuildId:20200519220135)
  • Firefox 78.0a1 (BuildId:20200520213050)

Unaffected versions

  • Firefox 68.8.0esr (BuildId:20200429190206)

Affected platforms

  • macOS 10.14

Unaffected platforms

  • Windows 10 64bit
  • Ubuntu 18.04 64bit

Steps to reproduce

  1. Launch Firefox.
  2. Access the about:support page.
  3. Press Command + P or click the Print button from the Hamburger menu.

Expected result

  • The about:support page is successfully printed.

Actual result

  • Nothing happens.

Regression Range
This seems to be a regression

Notes

  • The following error messages are displayed inside the Browser console:
  • [Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIPrintSettingsService.initPrintSettingsFromPrinter]" nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)" location: "JS frame :: resource://gre/actors/PrintingChild.jsm :: getPrintSettings :: line 134" data: no] PrintingChild.jsm:134:13 getPrintSettings resource://gre/actors/PrintingChild.jsm:134 print resource://gre/actors/PrintingChild.jsm:383 receiveMessage resource://gre/actors/PrintingChild.jsm:113 receiveMessage resource://gre/modules/ActorManagerChild.jsm:179
  • printSettings is null PrintingChild.jsm:386

Hi Jonathan,

It seems that mozregression pointed out Bug 1606512. Have save-as-PDF default to using the document title as the file name. r=bobowen for causing this issue.

Can you please take a look?

Thank you!

Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(jwatt)
Component: Printing → Printing: Setup
Product: Toolkit → Core

Erik, there's a decent chance that your work in bug 117233 fixes this, or at least gets us most of the way there. Can you check whether it does or does not?

Flags: needinfo?(jwatt) → needinfo?(enordin)

Sorry it took me a bit to get to this.

I can confirm that bug 117233 will fix this regression, and is queued for landing right now.

I verified the incorrect behavior on nightly.

And I verified that this page prints correctly on my local macOS build.

Flags: needinfo?(enordin)

That's landed now, and I just tested. For me I do now get the print dialog, but if I try to print to PDF I get a hang with the dialog still open. It seem that in nsPageSequenceFrame::Reflow we add a new frame every loop here which causes us to never exit that loop. Do you not experience that hang, Erik?

Flags: needinfo?(enordin)

Emil, would you be able to test other platforms (Windows, Linux) to see if the same hang occurs? I suspect this is a separate regression that has slipped in and may not be mac specific.

Flags: needinfo?(emil.ghitta)

I guess this is maybe now just a different manifistation of bug 1639816.

Hello,

I have tested on Windows 10x64, Ubuntu 18.04 and only managed to reproduce 1639816. I did not manage to trigger any hang while the dialog is still open like you have described in comment 4.

It is also worth mentioning that I have tried to reproduce the issue described by you in comment 4 and did not reproduce it on macOS 10.15.5

Flags: needinfo?(emil.ghitta)

I just tested print to PDF and print preview again on my machine. macOS 10.15.4

I tried my local build with and without fission,
I tried my nightly,
I tried nightly on a fresh profile,

All of them seemed to work as expected for me.

Flags: needinfo?(enordin)

I think some permutation of printing prefs that I had set probably caused this, although I've not been able to figure out which since messing with them subsequently. At any rate, this seems fixed (by bug 117233) for our shipped config. Thank you both for your replies.

Assignee: nobody → enordin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [print2020_v78]

Marking this bug as verified fixed since local pages can be successfully printed on macOS with Firefox 78.0b3 (BuildId:20200604213430) now.

Thanks!

Status: RESOLVED → VERIFIED
Flags: in-qa-testsuite+
Blocks: 1557682
You need to log in before you can comment on or make changes to this bug.