Make it more obvious that the scrollDelta used for adjusting the displayport is the same as the callback transform
Categories
(Core :: Panning and Zooming, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
Attachments
(1 file)
When investigating/fixing bug 1636911, Timothy made the observation that the "scroll delta" that we put in the callback transform in APZCCallbackHelper is the same quantity that is used to adjust the displayport. This is not obvious from looking at the code in APZCCallbackHelper, and I want to make it more obvious.
Assignee | ||
Comment 1•4 years ago
|
||
This makes it more obvious that we are using the same scrollDelta for adjusting
the displayport as we are for populating the callback transform. Instead of
computing the same value inside a helper, we just provide the helper with the
already-computed delta that is used for the callback transform too.
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=2af637feaa56576171fce92adb8be081a4e41aff should be better, I had a typo in the above try push where a .x
got turned into .y
.
Comment 5•4 years ago
|
||
bugherder |
Description
•