Closed Bug 1639825 Opened 8 months ago Closed 8 months ago

Make it more obvious that the scrollDelta used for adjusting the displayport is the same as the callback transform

Categories

(Core :: Panning and Zooming, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

When investigating/fixing bug 1636911, Timothy made the observation that the "scroll delta" that we put in the callback transform in APZCCallbackHelper is the same quantity that is used to adjust the displayport. This is not obvious from looking at the code in APZCCallbackHelper, and I want to make it more obvious.

This makes it more obvious that we are using the same scrollDelta for adjusting
the displayport as we are for populating the callback transform. Instead of
computing the same value inside a helper, we just provide the helper with the
already-computed delta that is used for the callback transform too.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd4b7928b25c
Some minor code reorganization. r=tnikkel
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.