1639842 - consoleActor is removed from listTabs and getTab method response

Status: RESOLVED INVALID

(DevTools :: Console, defect)

Description

[farhan.chauhan]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36

Steps to reproduce:

use listTabs or getTab debugging server method.

• start firefox with webdriverio.

const { remote } = require('webdriverio')

let client

(async () => {
client = await remote({
logLevel: 'trace',
capabilities: {
browserName: 'firefox',
'moz:firefoxOptions': {
args: [
'-start-debugger-server', '9222'
],
prefs: {
'devtools.debugger.remote-enabled': true,
'devtools.debugger.prompt-connection': false,
'devtools.chrome.enabled': true
}
}
}
})

await client.url('https://json.org')
await client.deleteSession()

})().catch(e => {
console.error(e)
client && client.deleteSession()
})

and send listTabs or getTabs to server.

Actual results:

With version 76 listTabs returns following response

{
preferenceActor: 'server1.conn6.preferenceActor2',
addonsActor: 'server1.conn6.addonsActor3',
deviceActor: 'server1.conn6.deviceActor4',
heapSnapshotFileActor: 'server1.conn6.heapSnapshotFileActor5',
perfActor: 'server1.conn6.perfActor6',
parentAccessibilityActor: 'server1.conn6.parentAccessibilityActor7',
selected: 0,
tabs: [ { actor: 'server1.conn6.tabDescriptor1', traits: [Object] } ],
from: 'root'
}

Expected results:

It should contain consoleActor. I am not sure if it's moved somewhere else, Please let me know if it's moved somewhere else. Thank you.

with version 74 result was like this:

{
preferenceActor: 'server1.conn2.preferenceActor3',
actorRegistryActor: 'server1.conn2.actorRegistryActor4',
addonsActor: 'server1.conn2.addonsActor5',
deviceActor: 'server1.conn2.deviceActor6',
heapSnapshotFileActor: 'server1.conn2.heapSnapshotFileActor7',
perfActor: 'server1.conn2.perfActor8',
selected: 0,
tabs: [
{
actor: 'server1.conn2.child1/frameTarget1',
browsingContextID: 9,
traits: [Object],
title: '',
url: 'about:blank',
outerWindowID: 17,
consoleActor: 'server1.conn2.child1/consoleActor2',
inspectorActor: 'server1.conn2.child1/inspectorActor3',
styleSheetsActor: 'server1.conn2.child1/styleSheetsActor4',
storageActor: 'server1.conn2.child1/storageActor5',
memoryActor: 'server1.conn2.child1/memoryActor6',
framerateActor: 'server1.conn2.child1/framerateActor7',
reflowActor: 'server1.conn2.child1/reflowActor8',
cssPropertiesActor: 'server1.conn2.child1/cssPropertiesActor9',
performanceActor: 'server1.conn2.child1/performanceActor10',
animationsActor: 'server1.conn2.child1/animationsActor11',
responsiveActor: 'server1.conn2.child1/responsiveActor12',
contentViewerActor: 'server1.conn2.child1/contentViewerActor13',
webExtensionInspectedWindowActor: 'server1.conn2.child1/webExtensionInspectedWindowActor14',
accessibilityActor: 'server1.conn2.child1/accessibilityActor15',
screenshotActor: 'server1.conn2.child1/screenshotActor16',
changesActor: 'server1.conn2.child1/changesActor17',
webSocketActor: 'server1.conn2.child1/webSocketActor18',
manifestActor: 'server1.conn2.child1/manifestActor19'
}
],
from: 'root'
}

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:Honza, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, sounds like Console related. Can you please look into it?

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

so I think that now listTabs return tabs descriptor (not sure for 76, but in Nightly: https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/devtools/server/actors/root.js#265-297).
TabDescriptors are defined here: https://searchfox.org/mozilla-central/source/devtools/server/actors/descriptors/tab.js#44

Comment 4

[farhan.chauhan]

I am able to fetch consoleActor using getTarget method of TabDescriptors.
Thanks a lot Nicolas.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

great! I'll close the bug.