1639942 - Switching between the Kinto and Rust extension storage engines doesn't work

Status: VERIFIED FIXED

(Firefox :: Sync, task)

Description

[Lina Butler [:lina]]

STR:

1. Flip the webextensions.storage.sync.kinto to false (it's true by default) to switch to the Rust engine.
2. Open the Browser Console.
3. Call Weave.Service.engineManager.switchAlternatives() to ensure the pref flip takes effect.
4. Type String(Weave.Service.engineManager.get('extension-storage')._sync) to check the source code.

Expected: The source of this function, indicating it's using the Rust sync engine.

Actual: This, so it's still using Kinto! 😱

(If you then sync and check about:sync-log, you'll notice log lines for Syncing extension settings for <add-on name>, which is also from Kinto).

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

I think markh said in the demo that it requires restarting after flipping the pref to take effect, no?

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1639942 - Correctly register `Extension-Storage` engine alternatives. r?tcsc!

Alternative engines are registered using the lowercased version of
the keys in the modules object. But extension-storage is hyphenated,
so we need to use Extension-Storage (not ExtensionStorage) as the
key name, to match the name of the engine and its collection.

Without the hyphen, we'll register the alternative as
extensionstorage, so it'll never be used because everything else
expects the engine to be called extension-storage.

Comment 3

[Lina Butler [:lina]]

Hmm, I think you do have to restart for the WebExtension API, but there might be another issue on the Sync side—we weren't registering the alternative under the right name (extension-storage vs. extensionstorage), so, even if you flipped the pref and restarted, it would still use Kinto.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f350b8dff15d
Correctly register `Extension-Storage` engine alternatives. r=tcsc

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f350b8dff15d

Comment 6

[Victor Carciu]

Verified as fixed in FF78.0b6. I will attach postfix screenshot

Comment 7

[Victor Carciu]

Attachment: Postfix screenshot