1639991 - Use offsetOf accessors for match result object slots

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Iain Ireland [:iain]]

Following up on a comment here:

In GenerateRegExpMatcherStub, we manually calculate offsets into the slots of the match result. This is kind of gross, and is getting grosser when named captures add another slot.

We should use offsetOf accessors.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1639991: Use offsetOf accessors for match result object slots r=jandem

Also did a drive-by comment clean-up I missed when adding dotAll.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41f104e3eeb1
Use offsetOf accessors for match result object slots r=jandem

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/41f104e3eeb1