Closed Bug 1639991 Opened 4 months ago Closed 4 months ago

Use offsetOf accessors for match result object slots

Categories

(Core :: JavaScript Engine: JIT, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: iain, Assigned: iain)

Details

Attachments

(1 file)

Following up on a comment here:

In GenerateRegExpMatcherStub, we manually calculate offsets into the slots of the match result. This is kind of gross, and is getting grosser when named captures add another slot.

We should use offsetOf accessors.

Also did a drive-by comment clean-up I missed when adding dotAll.

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41f104e3eeb1
Use offsetOf accessors for match result object slots r=jandem
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.