Closed Bug 1640014 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23735 - [AspectRatio] Correctly handle a stretched item in a fixed height flexbox

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23735 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23735
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[AspectRatio] Correctly handle a stretched item in a fixed height flexbox

With a fixed-height single-line flex container, a stretched item should be
considered to have a definite height and thus should have its aspect-ratio
calculated from that:
https://drafts.csswg.org/css-flexbox/#definite-sizes item 1

This patch limits this behavior to the CSS aspect-ratio property for now
(as opposed to supporting it for everything with an aspect ratio, like
images), to limit the behavior differences from pre-FlexNG Blink.

Bug: 1083020
Change-Id: I2abe33d49a8727857a28e47ba6344ad3da860cad
Reviewed-on: https://chromium-review.googlesource.com/2212984
WPT-Export-Revision: 972ca9aabfe1df816ddce04a71648ab4ce3f72f7

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/flex-aspect-ratio-009.tentative.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/edccacea76fc
[wpt PR 23735] - [AspectRatio] Correctly handle a stretched item in a fixed height flexbox, a=testonly
https://hg.mozilla.org/integration/autoland/rev/919781699601
[wpt PR 23735] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/edccacea76fc
https://hg.mozilla.org/mozilla-central/rev/919781699601

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.