164003 - Button "Add another boolean chart" appears twice after clicking "And"

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Robert Pollak]

Observed at http://bugzilla.mozilla.org/query.cgi :
After entering an "Advanced Query" term and clicking "And", the query page gets
two "Add another boolean chart" buttons.

Expected behavior:
Button only appears once. See e.g. the following installation of Bugzilla 2.14.1
for the correct behavior: http://itos.gsfc.nasa.gov/~bugzilla/query.cgi

Comment 1

[Bradley Baetz (:bbaetz)]

This is just cosmetic, and I'm not sure if it was done on purpose. gerv?

Comment 2

[Gervase Markham [:gerv]]

Even though it's cosmetic, I'd probably call that a bug :-) It should only
appear at the bottom.

Gerv

Comment 3

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This should do the trick.

Gerv

Comment 4

[Stephen Lee]

Also happens with [Or] button.

I found this regression independently when trying to apply my patch for bug 
92253. My latest patch on that bug also contains a (slightly different) fix for 
this bug.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 104415 [details] [diff] [review]
Patch v.1

r=myk

Comment 6

[Gervase Markham [:gerv]]

Dave: can I get a=, please? :-)

Gerv

Comment 7

[Dave Miller [:justdave]]

a= justdave

Comment 8

[Gervase Markham [:gerv]]

Fixed.

Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v
 <--  boolean-charts.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Gerv

Comment 9

[Dave Miller [:justdave]]

fixing milestone