Closed Bug 164003 Opened 22 years ago Closed 22 years ago

Button "Add another boolean chart" appears twice after clicking "And"

Categories

(Bugzilla :: Query/Bug List, defect)

2.16
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: robert.pollak, Assigned: gerv)

References

Details

(Keywords: polish, regression)

Attachments

(1 file)

Observed at http://bugzilla.mozilla.org/query.cgi :
After entering an "Advanced Query" term and clicking "And", the query page gets
two "Add another boolean chart" buttons.

Expected behavior:
Button only appears once. See e.g. the following installation of Bugzilla 2.14.1
for the correct behavior: http://itos.gsfc.nasa.gov/~bugzilla/query.cgi
Keywords: regression
This is just cosmetic, and I'm not sure if it was done on purpose. gerv?
Assignee: endico → gerv
Keywords: polish
Even though it's cosmetic, I'd probably call that a bug :-) It should only
appear at the bottom.

Gerv
Attached patch Patch v.1Splinter Review
This should do the trick.

Gerv
Also happens with [Or] button.

I found this regression independently when trying to apply my patch for bug 
92253. My latest patch on that bug also contains a (slightly different) fix for 
this bug.
Blocks: 92253
Version: 2.17 → 2.16
Comment on attachment 104415 [details] [diff] [review]
Patch v.1

r=myk
Attachment #104415 - Flags: review+
Dave: can I get a=, please? :-)

Gerv
a= justdave
Fixed.

Checking in template/en/default/search/boolean-charts.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/boolean-charts.html.tmpl,v
 <--  boolean-charts.html.tmpl
new revision: 1.2; previous revision: 1.1
done

Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
fixing milestone
Target Milestone: --- → Bugzilla 2.18
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: