1640141 - WebRender needs to be enabled when Fission is active

Status: RESOLVED WONTFIX

(Remote Protocol :: Marionette, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now when you run Marionette tests with Fission enabled Firefox complains that WebRender is not enabled, and that this combination is untested and on your own risk.

As such whenever --enable-fission has been specified we should enable WebRender.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Hm, I no longer see the yellow notification bar complaining that webrender is not enabled when running the Marionette tests with Fission enabled.

Chris, did something change recently?

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #2)

Hm, I no longer see the yellow notification bar complaining that webrender is not enabled when running the Marionette tests with Fission enabled.

Chris, did something change recently?

Yes. We removed the notification bar in bug 1639051, but we still only support Fission with WebRender. We just don't warn any longer. Eventually we'll add a runtime check. It might only enable Fission if WebRender is enabled or it might auto-enable WebRender. TBD!

In the meantime, I don't think the Marionette test runner should silently auto-enable WebRender just because a user or script set --enable-fission. We should only schedule Marionette on platform configs that enable Fission and WebRender. I don't think enforcing that is the responsibility of Marionette test runner. If a developer wants to run Marionette (locally or on Try) with Fission but not WebRender, we should allow that.

So I think you can WONTFIX this bug. If Fission is causing other Marionette problems, just let me know!

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Chris Peterson [:cpeterson] from comment #3)

Yes. We removed the notification bar in bug 1639051, but we still only support Fission with WebRender. We just don't warn any longer. Eventually we'll add a runtime check. It might only enable Fission if WebRender is enabled or it might auto-enable WebRender. TBD!

Thanks for the info. Good to know.

In the meantime, I don't think the Marionette test runner should silently auto-enable WebRender just because a user or script set --enable-fission. We should only schedule Marionette on platform configs that enable Fission and WebRender. I don't think enforcing that is the responsibility of Marionette test runner. If a developer wants to run Marionette (locally or on Try) with Fission but not WebRender, we should allow that.

So I think you can WONTFIX this bug. If Fission is causing other Marionette problems, just let me know!

Alright. But I will file a separate bug then to get Marionette test with Fission enabled running in CI. Right now we don't schedule it at all.