Mark nsINode parameters as const in editor
Categories
(Core :: DOM: Editor, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: saschanaz, Assigned: saschanaz)
Details
Attachments
(11 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Several editor functions including IsEditorRoot()
declares mutable nsINode
parameters when they don't mutate them. Those should be marked as const
.
Assignee | ||
Updated•8 months ago
|
Assignee | ||
Comment 1•8 months ago
|
||
Assignee | ||
Comment 2•8 months ago
|
||
Depends on D76562
Assignee | ||
Comment 3•8 months ago
|
||
Depends on D76563
Assignee | ||
Comment 4•8 months ago
|
||
Depends on D76564
Assignee | ||
Comment 5•8 months ago
|
||
Depends on D76565
Assignee | ||
Comment 6•8 months ago
|
||
Depends on D76567
Assignee | ||
Comment 7•8 months ago
|
||
Depends on D76569
Assignee | ||
Updated•8 months ago
|
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea0f8a5cacdc Part 1: Mark nsINode as const in Is*Root() r=masayuki https://hg.mozilla.org/integration/autoland/rev/ac943e455cf4 Part 2: Mark nsINode as const in Find*Node() r=masayuki https://hg.mozilla.org/integration/autoland/rev/77aab1a07cfc Part 3: Mark nsINode as const in GetNext/PreviousNodeInternal() r=masayuki https://hg.mozilla.org/integration/autoland/rev/65c499f35baa Part 4: Mark nsINode as const in GetNext/Previous*Node() r=masayuki https://hg.mozilla.org/integration/autoland/rev/d918b4d3936c Part 5: Mark nsINode as const in GetNext/PreviousGetNextHTMLElementOrTextInternal() r=masayuki https://hg.mozilla.org/integration/autoland/rev/54cdb503a915 Part 6: Mark nsINode as const in GetNext/PreviousHTMLElementOrText*() r=masayuki https://hg.mozilla.org/integration/autoland/rev/3dcbb4d3d972 Part 7: Mark nsINode as const in IsVisibleBRElement() r=masayuki
Comment 9•8 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ea0f8a5cacdc
https://hg.mozilla.org/mozilla-central/rev/ac943e455cf4
https://hg.mozilla.org/mozilla-central/rev/77aab1a07cfc
https://hg.mozilla.org/mozilla-central/rev/65c499f35baa
https://hg.mozilla.org/mozilla-central/rev/d918b4d3936c
https://hg.mozilla.org/mozilla-central/rev/54cdb503a915
https://hg.mozilla.org/mozilla-central/rev/3dcbb4d3d972
Updated•8 months ago
|
Assignee | ||
Updated•8 months ago
|
Assignee | ||
Updated•7 months ago
|
Assignee | ||
Comment 10•7 months ago
|
||
Assignee | ||
Comment 11•7 months ago
|
||
Depends on D80174
Assignee | ||
Comment 12•7 months ago
|
||
Depends on D80175
Assignee | ||
Comment 13•7 months ago
|
||
Depends on D80176
Updated•7 months ago
|
Comment 14•7 months ago
|
||
Pushed by krosylight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cce686c147ef Part 8: Mark nsINode as const in ComparePoint() r=masayuki https://hg.mozilla.org/integration/autoland/rev/295637e1ede1 Part 9: Mark nsINode as const in CompareBoundaryPoints() r=masayuki https://hg.mozilla.org/integration/autoland/rev/b32507be2c20 Part 10: Mark nsINode as const in IsPointInRange() r=masayuki https://hg.mozilla.org/integration/autoland/rev/0cf9ca67da48 Part 11: Mark nsINode as const in IsPointInSelection() r=masayuki
Comment 15•7 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cce686c147ef
https://hg.mozilla.org/mozilla-central/rev/295637e1ede1
https://hg.mozilla.org/mozilla-central/rev/b32507be2c20
https://hg.mozilla.org/mozilla-central/rev/0cf9ca67da48
Description
•