Closed Bug 1640276 Opened 2 months ago Closed 22 days ago

Mark nsINode parameters as const in editor

Categories

(Core :: DOM: Editor, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: saschanaz, Assigned: saschanaz)

Details

Attachments

(11 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Several editor functions including IsEditorRoot() declares mutable nsINode parameters when they don't mutate them. Those should be marked as const.

Assignee: nobody → krosylight
Keywords: leave-open
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea0f8a5cacdc
Part 1: Mark nsINode as const in Is*Root() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ac943e455cf4
Part 2: Mark nsINode as const in Find*Node() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/77aab1a07cfc
Part 3: Mark nsINode as const in GetNext/PreviousNodeInternal() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/65c499f35baa
Part 4: Mark nsINode as const in GetNext/Previous*Node() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d918b4d3936c
Part 5: Mark nsINode as const in GetNext/PreviousGetNextHTMLElementOrTextInternal() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/54cdb503a915
Part 6: Mark nsINode as const in GetNext/PreviousHTMLElementOrText*() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3dcbb4d3d972
Part 7: Mark nsINode as const in IsVisibleBRElement() r=masayuki
Severity: -- → N/A
Priority: -- → P2
Summary: Mark nsINode parameters as const → Mark nsINode parameters as const in editor
Keywords: leave-open
Attachment #9157616 - Attachment description: Bug 1640276 - Part 11: Mark nsINode as const in Bug 1640276 - Mark nsINode as const in IsPointInSelection() r=masayuki → Bug 1640276 - Part 11: Mark nsINode as const in IsPointInSelection() r=masayuki
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cce686c147ef
Part 8: Mark nsINode as const in ComparePoint() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/295637e1ede1
Part 9: Mark nsINode as const in CompareBoundaryPoints() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b32507be2c20
Part 10: Mark nsINode as const in IsPointInRange() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0cf9ca67da48
Part 11: Mark nsINode as const in IsPointInSelection() r=masayuki
You need to log in before you can comment on or make changes to this bug.