1640276 - Mark nsINode parameters as const in editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Kagami :saschanaz]

Several editor functions including IsEditorRoot() declares mutable nsINode parameters when they don't mutate them. Those should be marked as const.

Comment 1

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 1: Mark nsINode as const in Is*Root() r=masayuki

Comment 2

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 2: Mark nsINode as const in Find*Node() r=masayuki

Depends on D76562

Comment 3

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 3: Mark nsINode as const in GetNext/PreviousNodeInternal() r=masayuki

Depends on D76563

Comment 4

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 4: Mark nsINode as const in GetNext/Previous*Node() r=masayuki

Depends on D76564

Comment 5

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 5: Mark nsINode as const in GetNext/PreviousGetNextHTMLElementOrTextInternal() r=masayuki

Depends on D76565

Comment 6

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 6: Mark nsINode as const in GetNext/PreviousHTMLElementOrText*() r=masayuki

Depends on D76567

Comment 7

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 7: Mark nsINode as const in IsVisibleBRElement() r=masayuki

Depends on D76569

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea0f8a5cacdc
Part 1: Mark nsINode as const in Is*Root() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ac943e455cf4
Part 2: Mark nsINode as const in Find*Node() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/77aab1a07cfc
Part 3: Mark nsINode as const in GetNext/PreviousNodeInternal() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/65c499f35baa
Part 4: Mark nsINode as const in GetNext/Previous*Node() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d918b4d3936c
Part 5: Mark nsINode as const in GetNext/PreviousGetNextHTMLElementOrTextInternal() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/54cdb503a915
Part 6: Mark nsINode as const in GetNext/PreviousHTMLElementOrText*() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3dcbb4d3d972
Part 7: Mark nsINode as const in IsVisibleBRElement() r=masayuki

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ea0f8a5cacdc
https://hg.mozilla.org/mozilla-central/rev/ac943e455cf4
https://hg.mozilla.org/mozilla-central/rev/77aab1a07cfc
https://hg.mozilla.org/mozilla-central/rev/65c499f35baa
https://hg.mozilla.org/mozilla-central/rev/d918b4d3936c
https://hg.mozilla.org/mozilla-central/rev/54cdb503a915
https://hg.mozilla.org/mozilla-central/rev/3dcbb4d3d972

Comment 10

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 8: Mark nsINode as const in ComparePoint() r=masayuki

Comment 11

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 9: Mark nsINode as const in CompareBoundaryPoints() r=masayuki

Depends on D80174

Comment 12

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 10: Mark nsINode as const in IsPointInRange() r=masayuki

Depends on D80175

Comment 13

[Kagami :saschanaz]

Attachment: Bug 1640276 - Part 11: Mark nsINode as const in IsPointInSelection() r=masayuki

Depends on D80176

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cce686c147ef
Part 8: Mark nsINode as const in ComparePoint() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/295637e1ede1
Part 9: Mark nsINode as const in CompareBoundaryPoints() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b32507be2c20
Part 10: Mark nsINode as const in IsPointInRange() r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0cf9ca67da48
Part 11: Mark nsINode as const in IsPointInSelection() r=masayuki

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/cce686c147ef
https://hg.mozilla.org/mozilla-central/rev/295637e1ede1
https://hg.mozilla.org/mozilla-central/rev/b32507be2c20
https://hg.mozilla.org/mozilla-central/rev/0cf9ca67da48