Closed Bug 1640676 Opened 6 months ago Closed 6 months ago

Fix parent process and child process message managers following landing of Bug 888600

Categories

(Other Applications :: ChatZilla, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file, 1 obsolete file)

In Bug 888600 ContentFrameMessageManager was moved to WebIDL, we need to fix our one use of parentprocessmessagemanager in chatzilla-service.js (see part 6 of bug - https://hg.mozilla.org/mozilla-central/rev/243246b2f440)

Attached patch Fix parentprocessmessagemanager (obsolete) — Splinter Review

Fairly simple fix, just removes Ci.nsIMessageBroadcaster argument to match what has been done elsewhere.

Attachment #9151532 - Flags: review?(gijskruitbosch+bugs)

Also tested against software without Bug 888600 in and cZ is still spawned when clicking on irc links

Comment on attachment 9151532 [details] [diff] [review]
Fix parentprocessmessagemanager

r=me but I'd expect that really this only works on older apps if someone else has QI'd this to `nsIProcessScriptLoader` before we use it. Could do the QI on a second line if and only if `Ci.nsIProcessScriptLoader` exists?
Attachment #9151532 - Flags: review?(gijskruitbosch+bugs) → review+
Summary: Fix parentprocessmessagemanager following landing of Bug 888600 → Fix parent process and child process message managers following landing of Bug 888600

Now tests for existence of interfaces before trying to use them. Also fixed child process message manager and bumped the version.

Attachment #9151532 - Attachment is obsolete: true
Attachment #9151700 - Flags: review?(gijskruitbosch+bugs)
Attachment #9151700 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 9151700 [details] [diff] [review]
Fix message managers v1.1 {Checked in: Comment 5]

https://hg.mozilla.org/chatzilla/rev/8c47b210d980b0d5ba5fa72279a5e5fcf9277231
Attachment #9151700 - Attachment description: Fix message managers v1.1 → Fix message managers v1.1 {Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.