1640676 - Fix parent process and child process message managers following landing of Bug 888600

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Ian Neal]

In Bug 888600 ContentFrameMessageManager was moved to WebIDL, we need to fix our one use of parentprocessmessagemanager in chatzilla-service.js (see part 6 of bug - https://hg.mozilla.org/mozilla-central/rev/243246b2f440)

Comment 1

[Ian Neal]

Attachment: Fix parentprocessmessagemanager

Fairly simple fix, just removes Ci.nsIMessageBroadcaster argument to match what has been done elsewhere.

Comment 2

[Ian Neal]

Also tested against software without Bug 888600 in and cZ is still spawned when clicking on irc links

Comment 3

[:Gijs (he/him)]

Comment on attachment 9151532 [details] [diff] [review]
Fix parentprocessmessagemanager

r=me but I'd expect that really this only works on older apps if someone else has QI'd this to `nsIProcessScriptLoader` before we use it. Could do the QI on a second line if and only if `Ci.nsIProcessScriptLoader` exists?

Comment 4

[Ian Neal]

Attachment: Fix message managers v1.1 {Checked in: Comment 5]

Now tests for existence of interfaces before trying to use them. Also fixed child process message manager and bumped the version.

Comment 5

[Ian Neal]

Comment on attachment 9151700 [details] [diff] [review]
Fix message managers v1.1 {Checked in: Comment 5]

https://hg.mozilla.org/chatzilla/rev/8c47b210d980b0d5ba5fa72279a5e5fcf9277231