Closed Bug 1640716 Opened 11 months ago Closed 11 months ago

_read_mozbuild method is performing incorrect string substitution

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(firefox78 fixed)

RESOLVED FIXED
mozilla78
Tracking Status
firefox78 --- fixed

People

(Reporter: egao, Assigned: egao)

References

Details

Attachments

(1 file)

The method _read_mozbuild in file python/mozbuild/mozbuild/frontend/reader.py is performing incorrect string substitution.

Instead of

'Reading file: {path}'.format(path=path)
or the like, it is doing

'Reading file: {path}'

The in-tree code ends up producing a bunch of useless outputs when this line is hit:

 0:14.55 ----------------------------- Captured stdout call -----------------------------
 0:14.55 Test configuration changed. Regenerating backend.
 0:14.55 ------------------------------ Captured log call -------------------------------
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}
 0:14.55 reader.py                   92 DEBUG    Reading file: {path}

Presumably the log should output the path of the file being read, not just literally {path}.

Component: Task Configuration → General
Assignee: nobody → egao
Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e803948bb3cd
correct string substitution in mozbuild/frontend/reader.py r=jmaher
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.