1640772 - White sidebar line in about:addons dark theme

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[Andrei Petcu]

Attachment: Screenshot from 2020-05-26 03-15-01.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

I visited about:addons

Actual results:

I saw a white vertical border between the sidebar and the content

Expected results:

No white border.

Comment 1

[Andrei Petcu]

3:26.59 INFO: Narrowed nightly regression window from [2020-05-19, 2020-05-22] (3 days) to [2020-05-21, 2020-05-22] (1 days) (~0 steps left)
3:26.59 INFO: Got as far as we can go bisecting nightlies...
3:26.59 INFO: Last good revision: 92c11f0bf14b71b70bec5351212ae237707f4a62 (2020-05-21)
3:26.59 INFO: First bad revision: d6abd35b54ad39fa030217716b172fa9883bf3c8 (2020-05-22)
3:26.59 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=92c11f0bf14b71b70bec5351212ae237707f4a62&tochange=d6abd35b54ad39fa030217716b172fa9883bf3c8

3:26.59 INFO: Switching bisection method to taskcluster
3:26.59 INFO: Getting mozilla-central builds between 92c11f0bf14b71b70bec5351212ae237707f4a62 and d6abd35b54ad39fa030217716b172fa9883bf3c8
3:30.48 WARNING: Skipping build 92c11f0bf14b: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.92c11f0bf14b71b70bec5351212ae237707f4a62.firefox.linux64-opt'
3:30.48 WARNING: Skipping build d6abd35b54ad: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.d6abd35b54ad39fa030217716b172fa9883bf3c8.firefox.linux64-opt'
3:32.70 WARNING: Skipping build fbf71e4d2e21: Unable to find build info using the taskcluster route 'gecko.v2.mozilla-central.shippable.revision.fbf71e4d2e2142f823ac5d64679448443e25ec99.firefox.linux64-opt'
3:32.71 INFO: There are no build artifacts on inbound for these changesets (they are probably too old).

Comment 2

[Andrei Petcu]

Jerome, I saw you changed some theme-related stuff recently in this regression window. Can this be cause by one of your changes?

Comment 3

[Andrei Petcu]

I have Linux with Gnome Shell, Adwaita dark.

Comment 4

[Jerome Fray]

I modify only style files related to library -> https://hg.mozilla.org/mozilla-central/rev/40e834cc233c4744bba9b7e64ef9f7103a9e953a . I don't think they are loaded in "about:addons" page.

Comment 5

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Attachment: dark theme.PNG

Hi,
I'm not able to reproduce on ubuntu 18.04, nor win 10 pro. (using ff default dark theme, and add-on https://addons.mozilla.org/en-US/firefox/addon/dark-theme-for-firefox/) Which is the locale for your build? I'm using EN US nightly 79.0a1 (2020-06-19) (64-bit)
Best,
Clara

Comment 6

[Andrei Petcu]

I'm using Romanian locale

Comment 7

[Andrei Petcu]

I fixed it by commenting this

@media (prefers-reduced-motion) {
/* Setting border-inline-end on #sidebar makes it a focusable element /
#sidebar::after {
content: "";
width: 1px;
height: 100%;
/! background-color: var(--in-content-border-color); */
top: 0;
inset-inline-end: 0;
position: absolute;
}
}

Comment 8

[Andrei Petcu]

should I make a patch?

Comment 9

[Andrei Petcu]

Hmm, this one pixel border looks like it's as designed. The strange thing is that the @media (prefers-reduced-motion) media query gets triggered on my machine but not on yours, Clara. This is the bug that added it https://bugzilla.mozilla.org/show_bug.cgi?id=1610081

Jaws, can you please explain why one of us is seeing this border and the other one does not? I don't remember changing any preferences related to prefers-reduced-motion. Here is my about:support data http://paste.mozilla.org/q7a7tDEP

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

This line should only be visible if prefers-reduced-motion is enabled. On Windows you can enable it by going to the Windows Settings dialog, searching for "animation" and changing the "Show animation in Windows" setting to Off. I'm not sure how to change this setting on macOS or Linux.

Comments 4 and 5 don't mention having this or a similar setting for their respective OS applied.

I'm going to close this as invalid since the line is intentional.

Comment 11

[Andrei Petcu]

Attachment: disabled_animations_in_gnome.png

Comment 12

[Andrei Petcu]

I disabled animations in Gnome Tweaks. Enabling animations back, will make the border go away.