Closed Bug 1640773 Opened 11 months ago Closed 10 months ago

Remove unnecessary nsIFrameLoaderOwner QI from nsSessionStore.js

Categories

(SeaMonkey :: Session Restore, task)

Product:
SeaMonkey
Component:
Session Restore
Type:
task

Tracking

(seamonkey2.53 unaffected, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.77
Tracking Flags:
Tracking Status
seamonkey2.53 --- unaffected
seamonkey2.57esr ? affected

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Details

Attachments

(1 file)

Remove unnecessary QI
1.45 KB, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

We should remove the unnecessary nsIFrameLoaderOwner QI from nsSessionStore.js
The FrameLoaderOwner interface has been implemented in WebIDL for several years now, so these QIs are simply unnecessary overhead.
Bug 1391110 Part 4 covered similar work in m-c:
https://hg.mozilla.org/mozilla-central/rev/4b9198e17252
and Bug 1448933 did chat/
https://hg.mozilla.org/releases/comm-esr68/rev/82c2f54ceefd9e53fc84d6f02eccd7db3d0f5692

Simple fix

Attachment #9151626 - Flags: review?(frgrahl)
Attachment #9151626 - Flags: approval-comm-esr60?
Comment on attachment 9151626 [details] [diff] [review]
Remove unnecessary QI

LGTM
Attachment #9151626 - Flags: review?(frgrahl)
Attachment #9151626 - Flags: review+
Attachment #9151626 - Flags: approval-comm-esr60?
Attachment #9151626 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/1c831c29131d
Remove unnecessary nsIFrameLoaderOwner QI from nsSessionStore.js. r=frg

Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.77
You need to log in before you can comment on or make changes to this bug.