1640998 - Implement support actions API on MediaControlKeysEventSource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Per [1], we would like to implement supported actions for MediaControlKeysEventSource.

[1] https://w3c.github.io/mediasession/#supported-media-session-actions

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part1 : make `ContentMediaAgent` inherit from `IMediaInfoUpdater`.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part2 : use `ContentMediaAgent` to update media session's related information.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part3 : add methods to update supported action from media sessions.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part4 : update supported action changes from the content process.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part5 : set supported keys to the event source

Comment 6

[Alastor Wu [:alwu]]

Finish the first version, then I'm going to write tests.

Comment 7

[Alastor Wu [:alwu]]

Today's update, finish the webidl for exposing the media controller to Chrome JS, which allows us to write test easier and can be used for the MediaHub.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part6 : only notify the active media session's metadata change.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part7 : create `MediaController` webidl.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part8 : add test.

Comment 11

[Alastor Wu [:alwu]]

Because there are already too many patches on implementing supported action, I will move supporting PiP to another bug. In addition, will also file a bug for supporting controlling media before media starts, which is a request from Firefox Reality team.

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1640998 - part9 : use `MediaControlKey` to replace `MediaControlKeysEvent`

This patch will

• remove MediaControlKeysEvent and use MediaControlKey to replace it
• rename names for all MediaControlKey related methods, functions, classes and descriptions

The advantage of doing so are

• remove the duplicated type so that we only need to maintain MediaControlKey

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a042c009ea63
part1 : make `ContentMediaAgent` inherit from `IMediaInfoUpdater`. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/753f1c632de5
part2 : use `ContentMediaAgent` to update media session's related information. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3502f8c7a17d
part3 : add methods to update supported action from media sessions. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a48b6554ba9c
part4 : update supported action changes from the content process. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/714b2fb21e23
part5 : set supported keys to the event source r=chunmin
https://hg.mozilla.org/integration/autoland/rev/98843b4e9041
part6 : only notify the active media session's metadata change. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/8e04037ca021
part7 : create `MediaController` webidl. r=chunmin,smaug
https://hg.mozilla.org/integration/autoland/rev/e41abab613ae
part8 : add test. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/52e0f62534ea
part9 : use `MediaControlKey` to replace `MediaControlKeysEvent` r=chunmin,agi,geckoview-reviewers

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a042c009ea63
https://hg.mozilla.org/mozilla-central/rev/753f1c632de5
https://hg.mozilla.org/mozilla-central/rev/3502f8c7a17d
https://hg.mozilla.org/mozilla-central/rev/a48b6554ba9c
https://hg.mozilla.org/mozilla-central/rev/714b2fb21e23
https://hg.mozilla.org/mozilla-central/rev/98843b4e9041
https://hg.mozilla.org/mozilla-central/rev/8e04037ca021
https://hg.mozilla.org/mozilla-central/rev/e41abab613ae
https://hg.mozilla.org/mozilla-central/rev/52e0f62534ea