164103 - mouse wheel scrolling is too fast in jaguar (10.2)

Status: VERIFIED FIXED

(Camino Graveyard :: General, defect)

Description

[RalphNumbers]

Chimera scrolls much faster than most other apps under Jaguar when using the
mouse wheel.  
I believe this was originally a fix for scrolling being too slow under 10.1,
however Jaguar provides control of scrolling speed in System Prefrences.

Under 10.2 Chimera should scroll as a speed consistent with other apps for the
same settings in System Prefrences.

Reported in 2002082005 with the 10.2 update release.

Comment 1

[Sören 'Chucker' Kuklau (gone)]

C

Comment 2

[monkeypox37]

I'm not sure about the system mouse driver - I ditched that as soon as humanly
possible for USB Overdrive - but with an "accelerated" scrollwheel (# of lines
to scroll varies depending on how fast the wheel is turned) the hack used to get
around 10.1.x's lack of hardware acceleration for scrolling can quickly move you
past where you'd expect a simple wheel spin to go.

Comment 3

[saari (gone)]

->pinkerton

Comment 4

[Mike Pinkerton (not reading bugmail)]

-> dagley for a look

Comment 5

[Steve Dagley]

Looks simple, Under 10.1.x the deltaY in the scroll event was 1 or -1 so we
always multiply by -4 to get a larger interval.  Under 10.2 it's a variable # so
we need to take out our multiplier (or reduce it to 2x).  I'll do some
experimenting as soon as I find my extra scrollwheel mouse to hook up to my
machine running 10.2

Comment 6

[Steve Dagley]

Attachment: Patch to adjust for incoming deltaY

Under Jaguar the incoming deltaY for a scroll event depends on how fast the
scrollwheel is being turned and the user's setting of the Scrolling Speed pref
in the Mouse pref panl in System Preferences.  When it's >1 we don't want to be
multiplying it by 4x

Comment 7

[Steve Dagley]

Nominating for 0.5 since it's a simple fix and Jaguar is upon us

Comment 8

[Steve Dagley]

Attachment: New patch to handle different behavior under 10.2

This patch removes the hardcoded delta multiplier for scrollwheel deltaY whne
running under Mac OS X 10.2 or later.

Comment 9

[Patrick C. Beard]

Comment on attachment 96794 [details] [diff] [review]
New patch to handle different behavior under 10.2

Change hasCarbonWindowRef() to be more generally descriptive, and simply write
geckoEvent.delta = -incomingDeltaY, which is clearer to me.

Comment 10

[Steve Dagley]

Attachment: New patch addressing Patrick's comments

Comment 11

[Patrick C. Beard]

Comment on attachment 96800 [details] [diff] [review]
New patch addressing Patrick's comments

r=beard

Comment 12

[Simon Fraser [no longer active]]

Comment on attachment 96800 [details] [diff] [review]
New patch addressing Patrick's comments

sr=sfraser

Comment 13

[Steve Dagley]

Checked in

Comment 14

[sairuh (rarely reading bugmail)]

seems to work fine for me. fwiw, i'm using a Macally OptiJr on 10.2.2 (tested
with 2002.11.19.11).