Closed Bug 1641035 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 23779 - [css-grid] Fix 'grid-template-areas: inherit'

Categories

(Core :: Layout: Grid, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23779 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23779
Details from upstream follow.

Oriol Brufau <obrufau@igalia.com> wrote:

[css-grid] Fix 'grid-template-areas: inherit'

GridTemplateAreas::ApplyInherit wasn't setting ImplicitNamedGridRowLines
nor ImplicitNamedGridRowLines inherited from the parent, so grid items
referencing these lines were placed into the implicid grid.

The patch also makes sure to set them in GridTemplateAreas::ApplyInitial
and GridTemplateAreas::ApplyValue for a 'none' keyword. It seems these
weren't causing noticeable problems, though.

BUG=1085853

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-008.html

Change-Id: If92e771d51450dea3f7fa12deaec6ce9dd7639d1
Reviewed-on: https://chromium-review.googlesource.com/2214960
WPT-Export-Revision: 312bfe063fc0fbdcdef9fe6ae3dcbe7e249f0ddd

Component: web-platform-tests → Layout: Grid
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b0a8b44757
[wpt PR 23779] - [css-grid] Fix 'grid-template-areas: inherit', a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.