[wpt-sync] Sync PR 23795 - Fix "blocked-iframe-are-cross-origin.html".
Categories
(Core :: DOM: Security, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream][domsecurity-backlog])
Attachments
(3 files)
Sync web-platform-tests PR 23795 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23795
Details from upstream follow.
arthursonzogni <arthursonzogni@chromium.org> wrote:
Fix "blocked-iframe-are-cross-origin.html".
Reported by antoniosartori@, there was an error in the test:
"blocked_iframe-are-cross-origin.html"In Javascript, lambda capture is done by reference. The reference was
the loop 'variable'. As a result the second test case was run twice.The first test case couldn't work, because embedded enforcement do not
apply to same-origin iframes.The patch fixes the test.
Bug: 1041376
Change-Id: Id5f223aa138470cb263eea5b0af9f616a314a374
Reviewed-on: https://chromium-review.googlesource.com/2218049
WPT-Export-Revision: eefd714502d84a90b40df9d7ccb0d2c68fa7c7e4
|
Assignee | |
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24149471ee0b5b67f92b3f4c6dbe3cd82fb11169
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests and 2 subtests
Status Summary
Firefox
OK : 1
PASS: 1
FAIL: 1
Chrome
OK : 1
PASS: 2
Safari
OK : 1
PASS: 1
FAIL: 1
Links
Details
New Tests That Don't Pass
/content-security-policy/embedded-enforcement/blocked-iframe-are-cross-origin.html
Two same-origin iframes must appear as cross-origin when one is blocked: FAIL (Chrome: PASS, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24a0fb109de6 [wpt PR 23795] - Fix "blocked-iframe-are-cross-origin.html"., a=testonly
|
|
||
Updated•4 years ago
|
|
||
Comment 4•4 years ago
|
||
Automatic update from web-platform-tests
Fix "blocked-iframe-are-cross-origin.html".
Reported by antoniosartori@, there was an error in the test:
"blocked_iframe-are-cross-origin.html"
In Javascript, lambda capture is done by reference. The reference was
the loop 'variable'. As a result the second test case was run twice.
The first test case couldn't work, because embedded enforcement do not
apply to same-origin iframes.
The patch fixes the test.
TBR=mkwst@chromium.org
Bug: 1041376
Change-Id: Id5f223aa138470cb263eea5b0af9f616a314a374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218049
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774065}
--
wpt-commits: 2e45d1610c21b55ac4dcf4c223964d0d8069f3ee
wpt-pr: 23795
|
|
||
Comment 5•4 years ago
|
||
Automatic update from web-platform-tests
Fix "blocked-iframe-are-cross-origin.html".
Reported by antoniosartori@, there was an error in the test:
"blocked_iframe-are-cross-origin.html"
In Javascript, lambda capture is done by reference. The reference was
the loop 'variable'. As a result the second test case was run twice.
The first test case couldn't work, because embedded enforcement do not
apply to same-origin iframes.
The patch fixes the test.
TBR=mkwst@chromium.org
Bug: 1041376
Change-Id: Id5f223aa138470cb263eea5b0af9f616a314a374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218049
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774065}
--
wpt-commits: 2e45d1610c21b55ac4dcf4c223964d0d8069f3ee
wpt-pr: 23795
|
|
||
Comment 6•4 years ago
|
||
Automatic update from web-platform-tests
Fix "blocked-iframe-are-cross-origin.html".
Reported by antoniosartori@, there was an error in the test:
"blocked_iframe-are-cross-origin.html"
In Javascript, lambda capture is done by reference. The reference was
the loop 'variable'. As a result the second test case was run twice.
The first test case couldn't work, because embedded enforcement do not
apply to same-origin iframes.
The patch fixes the test.
TBR=mkwst@chromium.org
Bug: 1041376
Change-Id: Id5f223aa138470cb263eea5b0af9f616a314a374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218049
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774065}
--
wpt-commits: 2e45d1610c21b55ac4dcf4c223964d0d8069f3ee
wpt-pr: 23795
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/876ba714e9d7 [wpt PR 23795] - Fix "blocked-iframe-are-cross-origin.html"., a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/aa791e999522 [wpt PR 23795] - Fix "blocked-iframe-are-cross-origin.html"., a=testonly
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
Description
•