1641298 - Screenshots are shown for closed windows

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P2)

Description

[Florian Quèze [:florian]]

The profiler doesn't seem to record when a window is closed, so the profiler front-end keeps on showing the last screenshot of windows that have been closed.

The CompositorScreenshot markers have a windowID field that contains a pointer to the window object, but the DOMWindowClosed DOMEvent markers have a innerWindowID field that's an integer.

Comment 1

[Markus Stange [:mstange]]

It's not a pointer to the window object, it's a pointer to "something that only exists once per window". For example for the non-WebRender screenshots implementation, it's the address of the CompositorScreenshotGrabberImpl object.
So I think there are two ways to fix this: Either we carry the innerWindowID field all the way to the compositor (which might be tricky), or we emit CompositorScreenshotWindowDestroyed markers from the compositor screenshot infrastructure, for example from the CompositorScreenshotGrabberImpl destructor, with an appropriate windowID that matches the CompositorScreenshot markers.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:gerald, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Florian Quèze [:florian]]

Attachment: Bug 1641298 - record a CompositorScreenshotWindowDestroyed marker from ProfilerScreenshots to indicate to the profiler front-end that a window has been closed, r=mstange.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/960a24445eee
record a CompositorScreenshotWindowDestroyed marker from ProfilerScreenshots to indicate to the profiler front-end that a window has been closed, r=mstange.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/960a24445eee