Closed Bug 1641355 Opened 8 months ago Closed 7 months ago

Change AggregateError.errors to a data property on instances

Categories

(Core :: JavaScript Engine, task)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(1 file)

This appears to have been resolved informally in tc39/proposal-promise-any#38, though the proposal text does not reflect it yet.

Assignee: nobody → jorendorff
Severity: -- → N/A
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a8f7a2c1d507
Change AggregateError.errors to a data property on instances. r=tcampbell.

Backed out changeset a8f7a2c1d507 (bug 1641355) for mochitest failures at test_xrayToJS.xhtml on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/3ef71fbe016211e9a648fa84facee57e6c555871

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a8f7a2c1d5073d8d1e0904b941f44f6e51cf4e39&selectedTaskRun=NedfKHPXTrysTPcU9bN0uQ-0

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304244646&repo=autoland&lineNumber=9041

Log snippet:
[task 2020-05-29T11:41:51.254Z] 11:41:51 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | columnNumber property skipped after suspicious replacement
[task 2020-05-29T11:41:51.254Z] 11:41:51 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | lineNumber property is correct: 0
[task 2020-05-29T11:41:51.254Z] 11:41:51 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | lineNumber property ok after replacement: 50
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - TEST-PASS | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | lineNumber property skipped after suspicious replacement
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - Buffered messages finished
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - TEST-UNEXPECTED-FAIL | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | uncaught exception - TypeError: can't access property "length", errors is undefined at testErrorObjects@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:881:9
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - go@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:170:5
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - onload@chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml:1:1
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO -
[task 2020-05-29T11:41:51.255Z] 11:41:51 INFO - simpletestOnerror@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1940:18
[task 2020-05-29T11:41:51.256Z] 11:41:51 INFO - OnErrorEventHandlerNonNull*@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1915:1
[task 2020-05-29T11:41:51.256Z] 11:41:51 INFO - GECKO(920) | JavaScript error: chrome://mochitests/content/chrome/js/xpconnect/tests/chrome/test_xrayToJS.xhtml, line 881: TypeError: can't access property "length", errors is undefined
[task 2020-05-29T11:41:51.256Z] 11:41:51 INFO - GECKO(920) | MEMORY STAT | vsize 957MB | vsizeMaxContiguous 573MB | residentFast 319MB | heapAllocated 107MB
[task 2020-05-29T11:41:51.256Z] 11:41:51 INFO - TEST-OK | js/xpconnect/tests/chrome/test_xrayToJS.xhtml | took 2107ms

Flags: needinfo?(jorendorff)
Attachment #9152255 - Attachment description: Bug 1641355 - Change AggregateError.errors to a data property on instances. r?tcampbell. → Bug 1641355 - Change AggregateError.errors to a data property on instances. r?tcampbell, r?peterv.
Blocks: 1643397
Attachment #9152255 - Attachment description: Bug 1641355 - Change AggregateError.errors to a data property on instances. r?tcampbell, r?peterv. → Bug 1641355 - Change AggregateError.errors to a data property on instances. r?tcampbell,peterv.
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/320f586f954c
Change AggregateError.errors to a data property on instances. r=tcampbell,peterv.
Flags: needinfo?(jorendorff)
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Regressions: 1646317
You need to log in before you can comment on or make changes to this bug.