1641369 - SM(pkg) runs tests which don't exist for that revision

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Treeherder with push and ancestors and descendants

https://hg.mozilla.org/integration/autoland/rev/9a6631a07b7552cd81314c955c38d1f1f2276dee backed out bug 1640479 and removed the file js/src/jit-test/tests/regexp/bug1640479.js.

The SM(pkg) task shows the file being run as part of the tests (together with bug 1640475 which got backed out before). The files are as expected not part of the test folder.

The task looks sane (Gecko decision task is the one for that push, revision in payload is correct) and the log doesn't list these test files as part of the package.

Does an old artifact get pulled in?

Comment 1

[Intermittent Failures Robot]

1 failures in 5458 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1641369&startday=2020-05-25&endday=2020-05-31&tree=all

Comment 2

[Tooru Fujisawa [:arai]]

it's possible that the temporary directory is shared across multiple runs.
I'll make the script to remove the temporary directory if exists.

Comment 3

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #2)

it's possible that the temporary directory is shared across multiple runs.

looks like this isn't the case here.
the output of tar -xjvf /builds/worker/artifacts/mozjs-78.0a1.0.tar.bz2 in the log doesn't contain the file (js/src/jit-test/tests/regexp/bug1640475.js).
also, warning for reusing target directory isn't shown in the log https://searchfox.org/mozilla-central/rev/5e4d4827aa005d031580d2d17a01bae1af138b2e/js/src/make-source-package.py#247

This should be the case that ~/workspace/sm-package wasn't clean.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641369 - Part 2: Stop caching workspace directory in SpiderMonkey jobs. r?tomprince

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641369 - Part 5: Make sure the workspace is clean in SM package build. r?sfink!

Depends on D77642

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641369 - Part 1: Use GECKO_PATH instead of SRCDIR in SpiderMonkey jobs. r?tomprince!

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641369 - Part 3: Move objdir of SpiderMonkey jobs outside of checkouts directory. r?tomprince!

Depends on D77642

Comment 8

[Tooru Fujisawa [:arai]]

Attachment: Bug 1641369 - Part 4: Make clean command more robust. r?sfink!

Depends on D77991

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bfd5ebe307f
Part 1: Use GECKO_PATH instead of SRCDIR in SpiderMonkey jobs. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/0f3fe83ef886
Part 2: Stop caching workspace directory in SpiderMonkey jobs. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/9f777f1d5da0
Part 3: Move objdir of SpiderMonkey jobs outside of checkouts directory. r=tomprince
https://hg.mozilla.org/integration/autoland/rev/84fac4666ef1
Part 4: Make clean command more robust. r=sfink
https://hg.mozilla.org/integration/autoland/rev/df775aa81367
Part 5: Make sure the workspace is clean in SM package build. r=sfink

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8bfd5ebe307f
https://hg.mozilla.org/mozilla-central/rev/0f3fe83ef886
https://hg.mozilla.org/mozilla-central/rev/9f777f1d5da0
https://hg.mozilla.org/mozilla-central/rev/84fac4666ef1
https://hg.mozilla.org/mozilla-central/rev/df775aa81367