1641393 - Warn the user about how to handle the exported logins CSV file

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Description

[Matthew N. [:MattN]]

Attachment: Google/Chrome's warning

We should warn users that they need to protect the exported CSV file as the passwords inside it aren't encrypted therefore anyone with access has all their logins.

Example strings from Katie:
header: Export Logins
body: Logins and passwords will be saved as a csv file and anyone who has access can read it.
btns: cancel / Export logins...

Comment 1

[katieC]

Hi Michelle, we need a string for this modal, here's the user flow...

1. Clicks "..." menu (top right)
2. Selects "Export Logins..."
3. Gets (this) modal warning / Selects "Export Logins..."
4. OS Authentication
5. Save file dialog

2 main reasons a person might export their logins:
a. as backup
b. to import/move to another password manager

While we might not need to say all of this...
In the case of a) - we'd recommend they encrypt it
In the case of b) - we'd recommend they delete the file after import

Comment 2

[katieC]

Strings from Michelle (via slack)

hdr: Export logins and passwords
body: Your passwords will be saved as readable text (e.g., BadP@ssw0rd) so anyone who can open the exported file can view them.
btns: Cancel / Export...

Comment 3

[Andrei Petcu]

the dialog should be in the content, right? I tried to use it in the child but I don't see the show method.

Comment 4

[Matthew N. [:MattN]]

It would be in the unprivileged part, just like how the delete confirmation works I think.

Comment 5

[Andrei Petcu]

Attachment: export_confirm.gif

Comment 6

[Andrei Petcu]

Attachment: Bug 1641393 - Warn about the exported logins CSV file. r=MattN,fluent-reviewers

Depends on D77324

Comment 7

[Andrei Petcu]

Here is the review. I started working on the test https://phabricator.services.mozilla.com/D77376

Comment 8

[Matthew N. [:MattN]]

Thanks for taking this. Screenshot looks good except I think you may not have noticed the edit to the button string in comment 2. It should be "Export…" with an ellipsis character.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ac6f9017b79
Warn about the exported logins CSV file. r=MattN,fluent-reviewers

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9ac6f9017b79

Comment 11

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 79.0a1 (Build ID: 20200603214922) on Windows 10 x64, Ubuntu 18.04, Mac 10.14.6, Windows 7 x64.

• The “Export logins and passwords” dialog is displayed after selecting the “Export logins…” option from the menu.
• The dialog is correctly displayed and contains the following elements:
  • “Export logins and passwords” title.
  • “Your passwords will be saved as readable text (e.g., BadP@ssw0rd) so anyone who can open the exported file can view them.” text displayed under the title.
  • A red "Export..." button displayed on the left side of the dialog box.
  • A grey "Cancel" button displayed on the right side of the dialog box.