Closed Bug 1641393 Opened 4 months ago Closed 4 months ago

Warn the user about how to handle the exported logins CSV file

Categories

(Firefox :: about:logins, enhancement, P1)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
Firefox 78
Tracking Status
firefox78 --- fixed
firefox79 --- disabled

People

(Reporter: MattN, Assigned: petcuandrei)

References

Details

Attachments

(3 files)

Attached image Google/Chrome's warning

We should warn users that they need to protect the exported CSV file as the passwords inside it aren't encrypted therefore anyone with access has all their logins.

Example strings from Katie:
header: Export Logins
body: Logins and passwords will be saved as a csv file and anyone who has access can read it.
btns: cancel / Export logins...

Flags: qe-verify+

Hi Michelle, we need a string for this modal, here's the user flow...

  1. Clicks "..." menu (top right)
  2. Selects "Export Logins..."
  3. Gets (this) modal warning / Selects "Export Logins..."
  4. OS Authentication
  5. Save file dialog

2 main reasons a person might export their logins:
a. as backup
b. to import/move to another password manager

While we might not need to say all of this...
In the case of a) - we'd recommend they encrypt it
In the case of b) - we'd recommend they delete the file after import

Flags: needinfo?(mheubusch)

Strings from Michelle (via slack)

hdr: Export logins and passwords
body: Your passwords will be saved as readable text (e.g., BadP@ssw0rd) so anyone who can open the exported file can view them.
btns: Cancel / Export...

Flags: needinfo?(mheubusch)

the dialog should be in the content, right? I tried to use it in the child but I don't see the show method.

It would be in the unprivileged part, just like how the delete confirmation works I think.

Attached image export_confirm.gif

Here is the review. I started working on the test https://phabricator.services.mozilla.com/D77376

Thanks for taking this. Screenshot looks good except I think you may not have noticed the edit to the button string in comment 2. It should be "Export…" with an ellipsis character.

Assignee: nobody → petcuandrei
Status: NEW → ASSIGNED
Attachment #9152570 - Attachment description: Bug 1641393 Warn about the exported logins CSV → Bug 1641393 - Warn about the exported logins CSV file. r=MattN
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/9ac6f9017b79
Warn about the exported logins CSV file. r=MattN,fluent-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78
Attachment #9152570 - Attachment description: Bug 1641393 - Warn about the exported logins CSV file. r=MattN → Bug 1641393 Warn about the exported logins CSV
Attachment #9152570 - Attachment description: Bug 1641393 Warn about the exported logins CSV → Bug 1641393 - Warn about the exported logins CSV file. r=MattN,fluent-reviewers

I have verified this issue using the latest Firefox Nightly 79.0a1 (Build ID: 20200603214922) on Windows 10 x64, Ubuntu 18.04, Mac 10.14.6, Windows 7 x64.

  • The “Export logins and passwords” dialog is displayed after selecting the “Export logins…” option from the menu.
  • The dialog is correctly displayed and contains the following elements:
    • “Export logins and passwords” title.
    • “Your passwords will be saved as readable text (e.g., BadP@ssw0rd) so anyone who can open the exported file can view them.” text displayed under the title.
    • A red "Export..." button displayed on the left side of the dialog box.
    • A grey "Cancel" button displayed on the right side of the dialog box.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.