lookup for owner and peers for a file. add a field at the top of owners.html (and elsewhere)



16 years ago
2 years ago


(Reporter: asa, Assigned: myk)




(1 attachment, 1 obsolete attachment)



16 years ago
In the super-reviewers meeting today it was suggested that a lookup field for
owner and peers of specific file would be a good addition to the top of owners.html.

This would be a change to despot to allow people (without a login requirement)
to enter the name of the file they were hacking on into a field at the top of
the owners page and have it return the module in which that file lived along
with the names of the module owner and module peers. Something like this would
go a long way to help folks determine who should be giving reviews for a
particular change, re-inforcing the role of module owners and peers. It would
probably help us keep owners and peers in despot up to date as well. 

Right now you can do this by logging into despot and running a query but this is
sufficiently burried as to be mostly useless. Moving it to owners.html and
removint the despot login requirement fixes this problem. 

I also suggested that this information might also be reflected in the patch
tracker or the request tracker. No firm agreement on that idea.
Adding this one-field form to the request tracker (and whereever else makes
sense) is ok with me, so long as the results come back in a useful way.  Rather
than generating a page listing owner and peers, maybe they should come back in a
field in the current page, e.g.  Just so, on the owners.html page, maybe they
should navigate you to the named anchor for the module containing the file whose
relative pathname was input.  Etc.


Comment 2

16 years ago
Created attachment 98998 [details] [diff] [review]
patch v1: implements functionality in despot

This patch modifies despot in two ways: 1. makes it possible to run despot's
"Find Partition" command without logging in, and 2. redirects users to the
found partition's anchor on owners.html if "view=1" is added to the form

Once this patch is applied to despot, we can add a form to owners.html that
accepts a filename and calls despot to find the partition to which the file
belongs, which redirects the user back to the right place on owners.html.

Comment 3

16 years ago
Looks like dmose did the most recent hacking on despot.cgi.  cc:ing him for
review.  Dan, can you take a look at attachment 98998 [details] [diff] [review]?

Comment 4

16 years ago
Created attachment 99001 [details] [diff] [review]
patch v2: fixes problems with the previous patch

Missed a few things in the previous patch that broke parts of despot
functionality.	This patch fixes 'em.
Attachment #98998 - Attachment is obsolete: true
Comment on attachment 99001 [details] [diff] [review]
patch v2: fixes problems with the previous patch

Attachment #99001 - Flags: review+

Comment 6

16 years ago
Fix checked in and despot updated.  The form should appear on owners.html in a
few hours, once the site building script kicks in and builds that page.

Checking in despot.cgi;
/cvsroot/mozilla/webtools/despot/despot.cgi,v  <--  despot.cgi
new revision: 1.24; previous revision: 1.23
Checking in owners.templ;
/cvsroot/mozilla/webtools/despot/owners.templ,v  <--  owners.templ
new revision: 1.5; previous revision: 1.4
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
vrfy fixed (tested 'mozilla/configure.in')
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.