1641494 - Error: '' is not a valid command

Status: VERIFIED FIXED

(DevTools :: Console, defect, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

STR:

1. Load any page e.g. google.com
2. Open DevTools and select the Console panel
3. Type : in the command line
4. Check the Browser Console, it shows an error

Error: '' is not a valid command
    createToken resource://devtools/server/actors/webconsole/commands.js:72
    formatCommand resource://devtools/server/actors/webconsole/commands.js:39
    getEvalInput resource://devtools/server/actors/webconsole/eval-with-debugger.js:465
    evalWithDebugger resource://devtools/server/actors/webconsole/eval-with-debugger.js:122
    evaluateJS resource://devtools/server/actors/webconsole.js:1134
    evaluateJSAsync resource://devtools/server/actors/webconsole.js:1028
    executeSoon resource://devtools/shared/DevToolsUtils.js:47
    evaluateJSAsync resource://devtools/server/actors/webconsole.js:1025
    handler resource://devtools/shared/protocol/Actor.js:162
    onPacket resource://devtools/server/devtools-server-connection.js:380
    receiveMessage resource://devtools/shared/transport/child-transport.js:66
    _addListener resource://devtools/shared/transport/child-transport.js:40
    ready resource://devtools/shared/transport/child-transport.js:57
    _onConnection resource://devtools/server/devtools-server.js:471
    connectToParent resource://devtools/server/devtools-server.js:345
    onConnect resource://devtools/server/startup/frame.js:62
    makeInfallible resource://devtools/shared/ThreadSafeDevToolsUtils.js:103
    MessageListener.receiveMessage* resource://devtools/server/startup/frame.js:95
    <anonymous> resource://devtools/server/startup/frame.js:177
eval-with-debugger.js:467:15

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1641494 - Don't eagerly evaluate commands. r=Honza.

Depends on D77268

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b118006aae71
Don't eagerly evaluate commands. r=Honza.

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b118006aae71

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue using Firefox 78.0a1 (20200528215302) on Ubuntu 18.04.
The issue is verified fixed with Firefox 79.0b9 (20200717001501) on Windows 10x64, macOS 10.12 and Ubuntu 18.04.