Closed Bug 1641501 Opened 1 year ago Closed 11 months ago

[wpt-sync] Sync PR 23825 - Remove 'only' keyword and support 'dark' scheme with preferred 'light'.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23825 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23825
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:

Remove 'only' keyword and support 'dark' scheme with preferred 'light'.

This change makes 'only' behave like any other \<custom-ident>.

The used color-scheme can is now matching the preferred if listed, but
can also be 'dark' if 'light' is the preferred color-scheme but the
computed color-scheme only contains 'dark'.

These changes are per resolution[1]. Also improves interop with Safari.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3RhZFvZE1LM
[1] https://github.com/w3c/csswg-drafts/issues/3881#issuecomment-634799613

Bug: 1087115
Change-Id: I1b7aa199c0dab665ec72703c201ddc2831233cd3

Reviewed-on: https://chromium-review.googlesource.com/2218828
WPT-Export-Revision: 1abc0185ffe6d7b942c8d103721b11b9674ab428

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 10 tests and 23 subtests

Status Summary

Firefox

OK : 5
PASS : 15
FAIL : 39[GitHub] 41[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
ERROR: 2

Chrome

OK : 5
PASS : 45
FAIL : 11

Safari

OK : 5
PASS : 19
FAIL : 37

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-color-adjust/parsing/color-scheme-computed.html
Property color-scheme value 'light only': FAIL
Property color-scheme value 'light dark': FAIL
/css/css-color-adjust/parsing/color-scheme-valid.html
e.style['color-scheme'] = "dark" should set the property value: FAIL
e.style['color-scheme'] = "initial" should set the property value: FAIL
e.style['color-scheme'] = "light dark" should set the property value: FAIL
e.style['color-scheme'] = "light" should set the property value: FAIL
e.style['color-scheme'] = "light only" should set the property value: FAIL
e.style['color-scheme'] = "inherit" should set the property value: FAIL
e.style['color-scheme'] = "only light" should set the property value: FAIL
e.style['color-scheme'] = "dark light" should set the property value: FAIL
e.style['color-scheme'] = "unset" should set the property value: FAIL

New Tests That Don't Pass

/css/css-color-adjust/parsing/color-scheme-computed.html
Property color-scheme value 'initial': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'only only': FAIL (Chrome: FAIL, Safari: FAIL)
Property color-scheme value 'revert': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'only': FAIL (Chrome: FAIL, Safari: FAIL)
Property color-scheme value 'light only': FAIL (Chrome: PASS, Safari: PASS)
Property color-scheme value 'light unknown': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'none': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'only light': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'light light': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'dark light': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'inherit': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'normal': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'unset': FAIL (Chrome: PASS, Safari: FAIL)
Property color-scheme value 'light dark': FAIL (Chrome: PASS, Safari: PASS)
/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-change-checkbox.html: ERROR [GitHub], FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: FAIL, Safari: PASS)
/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-visited-link-initial.html: ERROR [GitHub], FAIL [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: PASS, Safari: FAIL)
/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-color-property.html
Check that color:initial resolves to the intial color for the light color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
Check that color:initial resolves to the intial color for the dark color-scheme.: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-color-adjust/parsing/color-scheme-valid.html
e.style['color-scheme'] = "light purple" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "dark" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "initial" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "light dark" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "only light dark" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
e.style['color-scheme'] = "light" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "only" should set the property value: FAIL (Chrome: FAIL, Safari: PASS)
e.style['color-scheme'] = "only only" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['color-scheme'] = "light only" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "only light purple" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['color-scheme'] = "only light light" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['color-scheme'] = "inherit" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "dark dark" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "purple dark interesting" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "only light" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "dark light" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "light none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "revert" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "none" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "normal" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)
e.style['color-scheme'] = "unset" should set the property value: FAIL (Chrome: PASS, Safari: PASS)
e.style['color-scheme'] = "only none" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['color-scheme'] = "light light" should set the property value: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ef472c765857
[wpt PR 23825] - Remove 'only' keyword and support 'dark' scheme with preferred 'light'., a=testonly
https://hg.mozilla.org/integration/autoland/rev/5939470bc756
[wpt PR 23825] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.